Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1564803002: Specialize message for parts as entry point (Closed)

Created:
4 years, 11 months ago by Johnni Winther
Modified:
4 years, 11 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -15 lines) Patch
M pkg/compiler/lib/src/diagnostics/dart2js_messages.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 1 chunk +18 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/diagnostic_helper.dart View 2 chunks +46 lines, -1 line 0 comments Download
M tests/compiler/dart2js/import_test.dart View 1 3 chunks +48 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 11 months ago (2016-01-06 14:35:53 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1564803002/diff/1/pkg/compiler/lib/src/diagnostics/messages.dart File pkg/compiler/lib/src/diagnostics/messages.dart (right): https://codereview.chromium.org/1564803002/diff/1/pkg/compiler/lib/src/diagnostics/messages.dart#newcode235 pkg/compiler/lib/src/diagnostics/messages.dart:235: LOAD_PART_OF, What about `MAIN_HAS_PART_OF`?
4 years, 11 months ago (2016-01-06 15:02:28 UTC) #3
Johnni Winther
https://codereview.chromium.org/1564803002/diff/1/pkg/compiler/lib/src/diagnostics/messages.dart File pkg/compiler/lib/src/diagnostics/messages.dart (right): https://codereview.chromium.org/1564803002/diff/1/pkg/compiler/lib/src/diagnostics/messages.dart#newcode235 pkg/compiler/lib/src/diagnostics/messages.dart:235: LOAD_PART_OF, On 2016/01/06 15:02:28, sigurdm wrote: > What about ...
4 years, 11 months ago (2016-01-07 08:41:07 UTC) #4
Johnni Winther
4 years, 11 months ago (2016-01-07 08:51:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c6f0d75d81a4a45817be1516449e1d3fe04be223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698