Issue 15648008: de-isolate Persistent::Dispose

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15648008: de-isolate Persistent::Dispose (Closed)

Created:
7 years, 7 months ago by dcarney

Modified:
7 years, 7 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

de-isolate Persistent::Dispose R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14764

Patch Set 1 #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -48 lines)			Patch
M	include/v8.h	View	2 chunks	+7 lines, -9 lines	2 comments	Download
M	src/api.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/global-handles.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/global-handles.cc	View	14 chunks	+42 lines, -33 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit. https://chromiumcodereview.appspot.com/15648008/diff/1/include/v8.h File include/v8.h (right): https://chromiumcodereview.appspot.com/15648008/diff/1/include/v8.h#newcode5497 include/v8.h:5497: void Persistent<T>::Dispose(Isolate* isolate) { I ...

7 years, 7 months ago (2013-05-23 08:09:11 UTC) #1

dcarney

https://chromiumcodereview.appspot.com/15648008/diff/1/include/v8.h File include/v8.h (right): https://chromiumcodereview.appspot.com/15648008/diff/1/include/v8.h#newcode5497 include/v8.h:5497: void Persistent<T>::Dispose(Isolate* isolate) { On 2013/05/23 08:09:11, Sven Panne ...

7 years, 7 months ago (2013-05-23 08:15:59 UTC) #2

dcarney

7 years, 7 months ago (2013-05-23 08:19:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14764 (presubmit successful).

Expand Messages | Collapse Messages