Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1564783003: Make m_pStockMap a real map. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make m_pStockMap a real map. Remove unused m_pContrastRamps. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a462162a76b3f487e76d8cc1b1f917f0937ea040

Patch Set 1 #

Patch Set 2 : Comment #

Total comments: 4

Patch Set 3 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -74 lines) Patch
M core/src/fpdfapi/fpdf_font/font_int.h View 1 3 chunks +23 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 2 1 chunk +41 lines, -68 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, for review.
4 years, 11 months ago (2016-01-07 01:10:01 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1564783003/diff/20001/core/src/fpdfapi/fpdf_font/fpdf_font.cpp File core/src/fpdfapi/fpdf_font/fpdf_font.cpp (right): https://codereview.chromium.org/1564783003/diff/20001/core/src/fpdfapi/fpdf_font/fpdf_font.cpp#newcode38 core/src/fpdfapi/fpdf_font/fpdf_font.cpp:38: for (size_t i = 0; i < FX_ArraySize(m_StockFonts); ...
4 years, 11 months ago (2016-01-07 02:39:19 UTC) #4
Tom Sepez
https://codereview.chromium.org/1564783003/diff/20001/core/src/fpdfapi/fpdf_font/fpdf_font.cpp File core/src/fpdfapi/fpdf_font/fpdf_font.cpp (right): https://codereview.chromium.org/1564783003/diff/20001/core/src/fpdfapi/fpdf_font/fpdf_font.cpp#newcode38 core/src/fpdfapi/fpdf_font/fpdf_font.cpp:38: for (size_t i = 0; i < FX_ArraySize(m_StockFonts); i++) ...
4 years, 11 months ago (2016-01-07 17:57:05 UTC) #5
Tom Sepez
4 years, 11 months ago (2016-01-07 20:06:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a462162a76b3f487e76d8cc1b1f917f0937ea040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698