fpdfsdk/src/formfiller/FFL_FormFiller.cpp - Issue 1564773003: Invalidate IPWL_FocusHandler and IPWL_Provider on destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/formfiller/FFL_FormFiller.cpp

Issue 1564773003: Invalidate IPWL_FocusHandler and IPWL_Provider on destruction. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/formfiller/FFL_FormFiller.cpp

diff --git a/fpdfsdk/src/formfiller/FFL_FormFiller.cpp b/fpdfsdk/src/formfiller/FFL_FormFiller.cpp

index 975385fb29c2078402f9cd2ff0b0c69781e6e0ad..146e0ab688ea3c4a35c39368b59f68f1c094c572 100644

--- a/fpdfsdk/src/formfiller/FFL_FormFiller.cpp

+++ b/fpdfsdk/src/formfiller/FFL_FormFiller.cpp

@@ -27,6 +27,7 @@ CFFL_FormFiller::~CFFL_FormFiller() {

for (auto& it : m_Maps) {

Tom Sepez 2016/01/06 19:58:26 nit: const auto& here too, we're not modifying the

Lei Zhang 2016/01/06 22:08:38 Done.

CPWL_Wnd* pWnd = it.second;

CFFL_PrivateData* pData = (CFFL_PrivateData*)pWnd->GetAttachedData();

+ pWnd->InvalidateProvider(this);

pWnd->Destroy();

delete pWnd;

delete pData;