third_party/zlib/google/zip.gyp - Issue 1564773002: Move components/compression to third_party/zlib/google

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/zlib/google/zip.gyp

Issue 1564773002: Move components/compression to third_party/zlib/google (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nico's review Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/zlib/google/zip.gyp

diff --git a/third_party/zlib/google/zip.gyp b/third_party/zlib/google/zip.gyp

index 9542f9cd668fec2871c4b0de2fdbf60b22d59748..a4328848e49be0ebf6fc1f59c65f50b1f6cc9319 100644

--- a/third_party/zlib/google/zip.gyp

+++ b/third_party/zlib/google/zip.gyp

@@ -23,5 +23,19 @@

'zip_reader.h',

+ {

+ 'target_name': 'compression_utils',

Nico 2016/01/07 15:03:42 You also need a GN version of this target, right?

hajimehoshi 2016/01/08 09:20:10 Done.

+ 'type': 'static_library',

+ 'dependencies': [

+ '../zlib.gyp:zlib',

+ ],

+ 'include_dirs': [

+ '../../..',

+ ],

+ 'sources': [

+ 'compression_utils.cc',

+ 'compression_utils.h',

+ ],

+ },

}

« no previous file with comments | « third_party/zlib/google/compression_utils_unittest.cc ('k') | no next file » | no next file with comments »