Move components/compression to third_party/zlib/google

Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a

Committed: https://crrev.com/1e1cc1a7060ab8eb95a62da608f333e31aaba475
Cr-Commit-Position: refs/heads/master@{#369491}

[hajimehoshi, 2016-01-06 11:05:41]

Description was changed from

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
==========

to

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
==========

[hajimehoshi, 2016-01-06 11:05:42]

hajimehoshi@chromium.org changed reviewers:
+ danakj@chromium.org, haraken@chromium.org, thakis@chromium.org

[hajimehoshi, 2016-01-06 11:05:53]

PTAL

[Nico, 2016-01-06 14:36:50]

Two comments about the new .gyp file, other than that looks good:

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/OWNERS
File third_party/zlib/google/OWNERS (right):

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/OWN...
third_party/zlib/google/OWNERS:4: # compression_utils.h, compression_utils.cc
that's a very long list of owners for such a small file! (not that there's
anything wrong with that -- but e.g. jar@ isn't doing much in chromium-land
anymore, so maybe take a second look at this list)

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/com...
File third_party/zlib/google/compression_utils.gyp (right):

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/com...
third_party/zlib/google/compression_utils.gyp:8: 'target_name':
'compression_utils',
I'd add this as a separate target to zip.gyp instead of creating another .gyp
file.

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/com...
third_party/zlib/google/compression_utils.gyp:11: 'zip.gyp:zip',
Do you want to depend on :zip? You don't use anything from there, do you?

[Alexei Svitkine (slow), 2016-01-06 16:21:23]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-01-06 16:21:23]

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/OWNERS
File third_party/zlib/google/OWNERS (right):

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/OWN...
third_party/zlib/google/OWNERS:4: # compression_utils.h, compression_utils.cc
On 2016/01/06 14:36:50, Nico wrote:
> that's a very long list of owners for such a small file! (not that there's
> anything wrong with that -- but e.g. jar@ isn't doing much in chromium-land
> anymore, so maybe take a second look at this list)

I think this was lifted from components/metrics owners, since that's where the
code originally came from. Realistically, it's probably fine to trim this list
to e.g. only myself and isherman@.

[hajimehoshi, 2016-01-07 07:40:10]

Thank you!

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/OWNERS
File third_party/zlib/google/OWNERS (right):

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/OWN...
third_party/zlib/google/OWNERS:4: # compression_utils.h, compression_utils.cc
On 2016/01/06 16:21:23, Alexei Svitkine wrote:
> On 2016/01/06 14:36:50, Nico wrote:
> > that's a very long list of owners for such a small file! (not that there's
> > anything wrong with that -- but e.g. jar@ isn't doing much in chromium-land
> > anymore, so maybe take a second look at this list)
> 
> I think this was lifted from components/metrics owners, since that's where the
> code originally came from. Realistically, it's probably fine to trim this list
> to e.g. only myself and isherman@.

Done (leaving asvitkine@ and isherman@).

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/com...
File third_party/zlib/google/compression_utils.gyp (right):

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/com...
third_party/zlib/google/compression_utils.gyp:8: 'target_name':
'compression_utils',
On 2016/01/06 14:36:50, Nico wrote:
> I'd add this as a separate target to zip.gyp instead of creating another .gyp
> file.

Done.

https://codereview.chromium.org/1564773002/diff/1/third_party/zlib/google/com...
third_party/zlib/google/compression_utils.gyp:11: 'zip.gyp:zip',
On 2016/01/06 14:36:50, Nico wrote:
> Do you want to depend on :zip? You don't use anything from there, do you?

No, done.

[hajimehoshi, 2016-01-07 07:44:00]

Description was changed from

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
==========

to

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
R=isherman@chromium.org, jochen@chromium.org
==========

[Nico, 2016-01-07 15:03:42]

https://codereview.chromium.org/1564773002/diff/20001/third_party/zlib/google...
File third_party/zlib/google/zip.gyp (right):

https://codereview.chromium.org/1564773002/diff/20001/third_party/zlib/google...
third_party/zlib/google/zip.gyp:27: 'target_name': 'compression_utils',
You also need a GN version of this target, right?

[Nico, 2016-01-07 15:03:56]

(add it to third_party/zlib/BUILD.gn)

[hajimehoshi, 2016-01-08 09:20:10]

Thanks. Additionally, I've fixed other BUILD.gn files.

https://codereview.chromium.org/1564773002/diff/20001/third_party/zlib/google...
File third_party/zlib/google/zip.gyp (right):

https://codereview.chromium.org/1564773002/diff/20001/third_party/zlib/google...
third_party/zlib/google/zip.gyp:27: 'target_name': 'compression_utils',
On 2016/01/07 15:03:42, Nico wrote:
> You also need a GN version of this target, right?

Done.

[Alexei Svitkine (slow), 2016-01-08 15:41:13]

lgtm

[Nico, 2016-01-08 15:44:28]

lgtm.

Looks like you need to update a few more include paths until the trybots are
happy (components\metrics\persisted_logs_unittest.cc(17) : fatal error C1083:
Cannot open include file: 'components/compression/compression_utils.h for
example)

[hajimehoshi, 2016-01-12 06:19:12]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2016-01-12 06:19:12]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1564773002/#ps80001
(title: "Fix #include")

[commit-bot: I haz the power, 2016-01-12 06:19:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564773002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564773002/80001

[commit-bot: I haz the power, 2016-01-12 06:24:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 06:24:23]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[hajimehoshi, 2016-01-12 07:34:00]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2016-01-12 07:34:00]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1564773002/#ps100001
(title: "Bug fix")

[commit-bot: I haz the power, 2016-01-12 07:34:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564773002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564773002/100001

[hajimehoshi, 2016-01-12 07:39:49]

The CQ bit was unchecked by hajimehoshi@chromium.org

[hajimehoshi, 2016-01-12 07:43:34]

Description was changed from

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
R=isherman@chromium.org, jochen@chromium.org
==========

to

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
==========

[hajimehoshi, 2016-01-12 07:43:34]

hajimehoshi@chromium.org changed reviewers:
+ isherman@chromium.org

[hajimehoshi, 2016-01-12 07:44:29]

hajimehoshi@chromium.org changed reviewers:
- isherman@chromium.org

[hajimehoshi, 2016-01-12 07:46:39]

Description was changed from

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
==========

to

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
TBR=jochen@chromium.org
==========

[hajimehoshi, 2016-01-12 07:47:04]

Description was changed from

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
TBR=jochen@chromium.org
==========

to

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
TBR=jochen@chromium.org, isherman@chromium.org
==========

[hajimehoshi, 2016-01-12 07:47:51]

Description was changed from

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
TBR=jochen@chromium.org, isherman@chromium.org
==========

to

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
==========

[hajimehoshi, 2016-01-12 07:47:51]

hajimehoshi@chromium.org changed reviewers:
+ isherman@chromium.org, jochen@chromium.org

[hajimehoshi, 2016-01-12 07:48:13]

+jochen, isherman: PTAL

[jochen (gone - plz use gerrit), 2016-01-12 15:48:31]

what part do you want me to look at?

[Ilya Sherman, 2016-01-13 01:10:11]

autofill lgtm

[Ilya Sherman, 2016-01-13 01:11:02]

On 2016/01/12 15:48:31, jochen wrote:
> what part do you want me to look at?

I'm guessing components/BUILD.gn, components/components.gyp, and
components/compression.gypi.

[hajimehoshi, 2016-01-13 04:48:14]

On 2016/01/13 01:11:02, Ilya Sherman wrote:
> On 2016/01/12 15:48:31, jochen wrote:
> > what part do you want me to look at?
> 
> I'm guessing components/BUILD.gn, components/components.gyp, and
> components/compression.gypi.

Right. Sorry for lack of explanation.

[hajimehoshi, 2016-01-14 11:08:50]

ping

[jochen (gone - plz use gerrit), 2016-01-14 13:57:15]

lgtm

[hajimehoshi, 2016-01-14 17:58:03]

The CQ bit was checked by hajimehoshi@chromium.org

[hajimehoshi, 2016-01-14 17:58:04]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
asvitkine@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1564773002/#ps160001
(title: "Fix another #include...")

[commit-bot: I haz the power, 2016-01-14 17:58:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564773002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564773002/160001

[commit-bot: I haz the power, 2016-01-14 19:09:08]

Description was changed from

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
==========

to

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
==========

[commit-bot: I haz the power, 2016-01-14 19:09:09]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-01-14 19:10:59]

Description was changed from

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a
==========

to

==========
Move components/compression to third_party/zlib/google

We are now implementing CompressibleString in third_party/WebKit/Source/
wtf/text and want to use compression algorithm, but wtf/text can't
depend on components. This CL moves components/compression to
third_party and enables wtf/text to use the compression utility.

The purpose of this CL is similar to crrev.com/14021015.

BUG=574317
TEST=n/a

Committed: https://crrev.com/1e1cc1a7060ab8eb95a62da608f333e31aaba475
Cr-Commit-Position: refs/heads/master@{#369491}
==========

[commit-bot: I haz the power, 2016-01-14 19:11:00]

Patchset 9 (id:??) landed as
https://crrev.com/1e1cc1a7060ab8eb95a62da608f333e31aaba475
Cr-Commit-Position: refs/heads/master@{#369491}