Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1564763002: Revert of Remove Pass() on Android. (Closed)

Created:
4 years, 11 months ago by msramek
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang, dcheng
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove Pass() on Android. (patchset #1 id:1 of https://codereview.chromium.org/1559603002/ ) Reason for revert: This breaks compilation, as there are still some callsites of Pass() left. See Android Cronet Data Reduction Proxy Builder build #961 and onwards: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Data%20Reduction%20Proxy%20Builder/builds/961/steps/compile/logs/stdio Original issue's description: > Remove Pass() on Android. > > Pass() is a legacy of the original C++03 move emulation implementation. > New code should use std::move from <utility>. > > ❆(੭ु ◜◡‾)੭ु⁾☃❆ > > BUG=557422 > R=thestig@chromium.org > > Committed: https://crrev.com/92469c8c4b7da052273dee1a31308663d1dd1e3d > Cr-Commit-Position: refs/heads/master@{#367251} TBR=thestig@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557422 Committed: https://crrev.com/f737edcf768bad1883164ac1c2270df670c7f6a9 Cr-Commit-Position: refs/heads/master@{#367811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/memory/scoped_ptr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/move.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
msramek
Created Revert of Remove Pass() on Android.
4 years, 11 months ago (2016-01-06 10:21:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564763002/1
4 years, 11 months ago (2016-01-06 10:22:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 10:23:11 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f737edcf768bad1883164ac1c2270df670c7f6a9 Cr-Commit-Position: refs/heads/master@{#367811}
4 years, 11 months ago (2016-01-06 10:24:59 UTC) #6
dcheng
On 2016/01/06 at 10:24:59, commit-bot wrote: > Patchset 1 (id:??) landed as https://crrev.com/f737edcf768bad1883164ac1c2270df670c7f6a9 > Cr-Commit-Position: ...
4 years, 11 months ago (2016-01-06 13:57:48 UTC) #7
dcheng
On 2016/01/06 at 13:57:48, dcheng wrote: > On 2016/01/06 at 10:24:59, commit-bot wrote: > > ...
4 years, 11 months ago (2016-01-06 13:58:17 UTC) #8
dcheng
On 2016/01/06 at 13:57:48, dcheng wrote: > On 2016/01/06 at 10:24:59, commit-bot wrote: > > ...
4 years, 11 months ago (2016-01-06 13:58:18 UTC) #9
dcheng
On 2016/01/06 at 13:57:48, dcheng wrote: > On 2016/01/06 at 10:24:59, commit-bot wrote: > > ...
4 years, 11 months ago (2016-01-06 13:58:18 UTC) #10
dcheng
4 years, 11 months ago (2016-01-06 14:15:51 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1562043002/ by dcheng@chromium.org.

The reason for reverting is: Relanding because the build config in question is
not covered by any trybots or the default waterfall.

Per the discussion:
1) Keeping this reverted makes things harder to reland, due to the possibility
of mid-air collisions.
2) The remaining failures will be fixed shortly afterwards in a followup patch..

Powered by Google App Engine
This is Rietveld 408576698