Copier should copy InvokeMethod calling convention

Copier should copy InvokeMethod calling convention

R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/55e8ae0e100d47d0a9a31a2d08be4dcec324d872

[sra1, 2016-01-06 04:09:15]

sra@google.com changed reviewers:
+ asgerf@google.com

[asgerf, 2016-01-06 15:38:33]

https://codereview.chromium.org/1564713002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart (right):

https://codereview.chromium.org/1564713002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:2487: ..callingConvention =
node.callingConvention;
While you're at it, could you add this as a named argument to the constructor?
(cps_ir_fragment also does this in one place)

I have (with partial success) tried to uphold the convention that the fields
which are part of the concrete semantics can be passed in the constructor (as
opposed to derived properties like the type).

[sra1, 2016-01-06 20:42:04]

https://codereview.chromium.org/1564713002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart (right):

https://codereview.chromium.org/1564713002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart:2487: ..callingConvention =
node.callingConvention;
On 2016/01/06 15:38:33, asgerf wrote:
> While you're at it, could you add this as a named argument to the constructor?
> (cps_ir_fragment also does this in one place)
> 
> I have (with partial success) tried to uphold the convention that the fields
> which are part of the concrete semantics can be passed in the constructor (as
> opposed to derived properties like the type).

Done.

[asgerf, 2016-01-06 20:45:46]

I meant to say LGTM. Nice catch!

[sra1, 2016-01-06 21:07:21]

Description was changed from

==========
Copier should copy InvokeMethod calling convention
==========

to

==========
Copier should copy InvokeMethod calling convention

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/55e8ae0e100d47d0a9a31a2d08be4dcec324d872
==========

[sra1, 2016-01-06 21:07:24]

Committed patchset #2 (id:20001) manually as
55e8ae0e100d47d0a9a31a2d08be4dcec324d872 (presubmit successful).