Implement external stencil for Android WebView

Implement external stencil for Android WebView

Add an OutputSurface::ApplyExternalStencil method.
Android WebView implements this method on the render thread
and applies the stencil parameters read in functor, through
the command buffer client.

BUG=574570
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0ed4f6567c1b77cea282fac1773dfbaa2ac0c939
Cr-Commit-Position: refs/heads/master@{#368468}

[boliu, 2016-01-06 19:42:56]

Description was changed from

==========
Implement external stencil for Android WebView

BUG=574570
==========

to

==========
Implement external stencil for Android WebView

BUG=574570
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[boliu, 2016-01-06 19:48:53]

Description was changed from

==========
Implement external stencil for Android WebView

BUG=574570
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement external stencil for Android WebView

Add an OutputSurface::ApplyExternalStencil method.
Android WebView implements this method on the render thread
and applies the stencil parameters read in functor, through
the command buffer client. 

BUG=574570
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[boliu, 2016-01-06 19:50:27]

boliu@chromium.org changed reviewers:
+ aelias@chromium.org

[boliu, 2016-01-06 19:50:27]

any high level objections/comments?

haven't bothered to look into cc pixel test failures, but I assume it's due to
removing the StencilFunc call in GLRenderer

[aelias_OOO_until_Jul13, 2016-01-06 23:43:36]

No major objections.

https://codereview.chromium.org/1564703005/diff/1/cc/output/output_surface.h
File cc/output/output_surface.h (right):

https://codereview.chromium.org/1564703005/diff/1/cc/output/output_surface.h#...
cc/output/output_surface.h:94: virtual bool HasExternalStencilTest() const;
Maybe this could be replaced by a bool returned from ApplyExternalStencil?

[boliu, 2016-01-07 15:42:43]

ptal, fixed pixel tests by adding back that StencilFunc call

https://codereview.chromium.org/1564703005/diff/1/cc/output/output_surface.h
File cc/output/output_surface.h (right):

https://codereview.chromium.org/1564703005/diff/1/cc/output/output_surface.h#...
cc/output/output_surface.h:94: virtual bool HasExternalStencilTest() const;
On 2016/01/06 23:43:36, aelias wrote:
> Maybe this could be replaced by a bool returned from ApplyExternalStencil?

Then there is no way to do this DCHECK in software_renderer that there is no
external stencil:
https://code.google.com/p/chromium/codesearch#chromium/src/cc/output/software...

[aelias_OOO_until_Jul13, 2016-01-08 21:48:10]

lgtm

[boliu, 2016-01-08 21:48:38]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2016-01-08 21:50:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564703005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564703005/20001

[commit-bot: I haz the power, 2016-01-09 00:07:33]

Description was changed from

==========
Implement external stencil for Android WebView

Add an OutputSurface::ApplyExternalStencil method.
Android WebView implements this method on the render thread
and applies the stencil parameters read in functor, through
the command buffer client. 

BUG=574570
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement external stencil for Android WebView

Add an OutputSurface::ApplyExternalStencil method.
Android WebView implements this method on the render thread
and applies the stencil parameters read in functor, through
the command buffer client. 

BUG=574570
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-01-09 00:07:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-09 00:08:53]

Description was changed from

==========
Implement external stencil for Android WebView

Add an OutputSurface::ApplyExternalStencil method.
Android WebView implements this method on the render thread
and applies the stencil parameters read in functor, through
the command buffer client. 

BUG=574570
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement external stencil for Android WebView

Add an OutputSurface::ApplyExternalStencil method.
Android WebView implements this method on the render thread
and applies the stencil parameters read in functor, through
the command buffer client.

BUG=574570
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0ed4f6567c1b77cea282fac1773dfbaa2ac0c939
Cr-Commit-Position: refs/heads/master@{#368468}
==========

[commit-bot: I haz the power, 2016-01-09 00:08:53]

Patchset 2 (id:??) landed as
https://crrev.com/0ed4f6567c1b77cea282fac1773dfbaa2ac0c939
Cr-Commit-Position: refs/heads/master@{#368468}