Revert 202152 "RulesRegistryWithCache::ProcessChangedRules speed-up"

Revert 202152 "RulesRegistryWithCache::ProcessChangedRules speed-up"

> RulesRegistryWithCache::ProcessChangedRules speed-up
>
> Postpone rules->value conversion:
> Currently the rules are converted to base::Value on the rules registry thread before ProcessChangedRules finishes, and then a task is posted to UI which will trigger writing that to a rule store on yet another thread.
> This CL postpones the conversion to the task running on UI thread.
>
> This change cuts down the running time for AddRules to 75%, but of course this is cheating, since the work only gets done later. The point is, however, that network requests are not blocked until the rules are written.
>
> BUG=236368
>
> Review URL: https://chromiumcodereview.appspot.com/14851011

TBR=vabr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202342

[xiyuan, 2013-05-26 03:24:26]

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

TrayAccessibilityTest.ShowMenu
...
[5714:5714:0524/155907:6899660627:FATAL:weak_ptr.cc(20)] Check failed:
thread_checker_.CalledOnValidThread() || HasOneRef(). WeakPtrs must be checked
and invalidated on the same thread.
[0x7f834b28da3c] base::debug::StackTrace::StackTrace()
[0x7f834b2cad27] logging::LogMessage::~LogMessage()
[0x7f834b2cf7ef] base::internal::WeakReference::Flag::Invalidate()
[0x7f834b2cfa82] base::internal::WeakReferenceOwner::Invalidate()
[0x7f834b2cf9cc] base::internal::WeakReferenceOwner::~WeakReferenceOwner()
[0x000001ef1fde] base::WeakPtrFactory<>::~WeakPtrFactory()
[0x000001eefc8c] extensions::RulesRegistryWithCache::~RulesRegistryWithCache()
[0x000001c45fd4] extensions::WebRequestRulesRegistry::~WebRequestRulesRegistry()
[0x000001c46006] extensions::WebRequestRulesRegistry::~WebRequestRulesRegistry()
[0x000000a76c2e] base::RefCountedThreadSafe<>::DeleteInternal()
[0x000000a76a36] base::DefaultRefCountedThreadSafeTraits<>::Destruct()
[0x000000a76762] base::RefCountedThreadSafe<>::Release()
[0x000000a76575] scoped_refptr<>::~scoped_refptr()
[0x000001eed81c]
extensions::InitializingRulesRegistry::~InitializingRulesRegistry()
[0x000001eed85a]
extensions::InitializingRulesRegistry::~InitializingRulesRegistry()
[0x000000a76c2e] base::RefCountedThreadSafe<>::DeleteInternal()
[0x000000a76a36] base::DefaultRefCountedThreadSafeTraits<>::Destruct()
[0x000000a76762] base::RefCountedThreadSafe<>::Release()
[0x000000a76575] scoped_refptr<>::~scoped_refptr()
[0x000001c325dc] std::pair<>::~pair()
[0x000001c33db6] __gnu_cxx::new_allocator<>::destroy()
[0x000001c331a2] std::_Rb_tree<>::_M_destroy_node()
[0x000001c329c1] std::_Rb_tree<>::_M_erase()
[0x000001c322ce] std::_Rb_tree<>::~_Rb_tree()
[0x000001c321e6] std::map<>::~map()
[0x000001c31a0a] extensions::RulesRegistryService::~RulesRegistryService()
[0x000001c31a48] extensions::RulesRegistryService::~RulesRegistryService()
[0x000001e44d62] base::DefaultDeleter<>::operator()()
[0x000001e43d86] base::internal::scoped_ptr_impl<>::~scoped_ptr_impl()
[0x000001e43486] scoped_ptr<>::~scoped_ptr()
[0x000001e42a8f] extensions::ExtensionSystemImpl::~ExtensionSystemImpl()
[0x000001e42b0e] extensions::ExtensionSystemImpl::~ExtensionSystemImpl()
[0x000001bd87af] BrowserContextKeyedServiceFactory::BrowserContextDestroyed()
[0x000001bd5ab6]
BrowserContextDependencyManager::DestroyBrowserContextServices()
[0x00000152d221] ProfileImpl::~ProfileImpl()
[0x00000152d4b2] ProfileImpl::~ProfileImpl()
[0x0000018dac94] ProfileDestroyer::DestroyProfileWhenAppropriate()
[0x0000015517e8] ProfileManager::ProfileInfo::~ProfileInfo()
[0x000001553189] linked_ptr<>::depart()
[0x000001551e64] linked_ptr<>::~linked_ptr()
[0x000001551904] std::pair<>::~pair()
[0x00000155510c] __gnu_cxx::new_allocator<>::destroy()
[0x000001553e82] std::_Rb_tree<>::_M_destroy_node()
[0x00000155262d] std::_Rb_tree<>::_M_erase()
[0x00000155260a] std::_Rb_tree<>::_M_erase()
[0x0000015519f0] std::_Rb_tree<>::~_Rb_tree()
[0x00000155186e] std::map<>::~map()
[0x00000154d139] ProfileManager::~ProfileManager()
[0x00000154d1c0] ProfileManager::~ProfileManager()
[0x0000019db580] base::DefaultDeleter<>::operator()()
[0x0000019dc141] base::internal::scoped_ptr_impl<>::reset()
[0x0000019da7d5] scoped_ptr<>::reset()
[0x0000019d5cb4] BrowserProcessImpl::StartTearDown()
[0x000003260f14] ChromeBrowserMainParts::PostMainMessageLoopRun()
[0x000003263996] ChromeBrowserMainPartsLinux::PostMainMessageLoopRun()
[0x000002112273]
chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun()
[0x7f83406fcd37] content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
[0x7f8340701a7a] content::BrowserMainRunnerImpl::Shutdown()
[0x7f83406fa4b2] content::BrowserMain()
[0x0000033066ba] content::BrowserTestBase::SetUp()
[0x00000209168e] InProcessBrowserTest::SetUp()

[xiyuan, 2013-05-26 03:24:53]

Committed patchset #1 manually as r202342.

[vabr (Chromium), 2013-05-27 07:29:27]

On 2013/05/26 03:24:53, xiyuan wrote:
> Committed patchset #1 manually as r202342.

LGTM, thanks for reverting this!

Vaclav