Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 1564583002: [turbofan] Splinter when range ends at hot block start (Closed)

Created:
4 years, 11 months ago by Mircea Trofin
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Splinter when range ends at hot block start We were sometimes losing a splintering opportunity when a range was ending at the beginning of a hot (==non-deferred) block, when giving its value to some fixed range - i.e. a fixed operand of the first instruction in that hot block. Renamed 2 APIs to better reflect what their intent is. Added self-checking when introducing moves connecting ranges, to ensure we don't spill/fill in hot blocks ranges spilled only in deferred blocks. Verified locally that these checks would have tripped in a few cases before this change. BUG= Committed: https://crrev.com/83683e92e1d1cc66d3734da4c7f5229925b0d2de Cr-Commit-Position: refs/heads/master@{#33301}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -23 lines) Patch
M src/compiler/instruction.h View 2 chunks +9 lines, -5 lines 0 comments Download
M src/compiler/live-range-separator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/register-allocator.h View 2 chunks +10 lines, -8 lines 0 comments Download
M src/compiler/register-allocator.cc View 5 chunks +20 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Mircea Trofin
4 years, 11 months ago (2016-01-14 07:12:08 UTC) #7
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-14 11:58:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564583002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564583002/80001
4 years, 11 months ago (2016-01-14 16:08:31 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 11 months ago (2016-01-14 16:28:43 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 16:29:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83683e92e1d1cc66d3734da4c7f5229925b0d2de
Cr-Commit-Position: refs/heads/master@{#33301}

Powered by Google App Engine
This is Rietveld 408576698