Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1998)

Unified Diff: test/cctest/wasm/test-run-wasm-module.cc

Issue 1564553002: Disable more crashing / failing wasm tests. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/wasm/test-run-wasm.cc ('k') | test/unittests/wasm/ast-decoder-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/wasm/test-run-wasm-module.cc
diff --git a/test/cctest/wasm/test-run-wasm-module.cc b/test/cctest/wasm/test-run-wasm-module.cc
index 3b7bae1dda6ac9b6872c1254b79ca44c3eca1b7b..56a0f661a435b9570efd2bbc343518b6f8b6afa3 100644
--- a/test/cctest/wasm/test-run-wasm-module.cc
+++ b/test/cctest/wasm/test-run-wasm-module.cc
@@ -28,6 +28,9 @@ void TestModule(WasmModuleIndex* module, int32_t expected_result) {
} // namespace
+// TODO(tizer): Figure out why this crashes with PPC.
+#if !defined(V8_TARGET_ARCH_PPC) && !defined(V8_TARGET_ARCH_PPC64)
+
// A raw test that skips the WasmModuleBuilder.
TEST(Run_WasmModule_CallAdd_rev) {
static const byte data[] = {
@@ -55,6 +58,8 @@ TEST(Run_WasmModule_CallAdd_rev) {
CHECK_EQ(99, result);
}
+#endif
+
TEST(Run_WasmModule_Return114) {
static const int32_t kReturnValue = 114;
@@ -146,7 +151,9 @@ TEST(Run_WasmModule_CheckMemoryIsZero) {
#endif
-#if !defined(V8_WITH_ASAN)
+#if !defined(V8_WITH_ASAN) && !defined(V8_TARGET_ARCH_PPC) && \
+ !defined(V8_TARGET_ARCH_PPC64)
+// TODO(tizer): Figure out why this crashes with PPC.
// TODO(bradnelson): Figure out why this crashes under asan.
TEST(Run_WasmModule_CallMain_recursive) {
Zone zone;
@@ -172,7 +179,9 @@ TEST(Run_WasmModule_CallMain_recursive) {
#endif
-#if !defined(V8_WITH_ASAN)
+#if !defined(V8_WITH_ASAN) && !defined(V8_TARGET_ARCH_PPC) && \
+ !defined(V8_TARGET_ARCH_PPC64)
+// TODO(tizer): Figure out why this fails with PPC.
// TODO(bradnelson): Figure out why this crashes under asan.
TEST(Run_WasmModule_Global) {
Zone zone;
« no previous file with comments | « test/cctest/wasm/test-run-wasm.cc ('k') | test/unittests/wasm/ast-decoder-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698