Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3226)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

Issue 15645004: [rAC] Allow sub-views to trigger layout reflow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments, declare protocol. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
index 191f81ab50e0e0d18858f8547a083d3bda06115d..2df23fdc865d2893fc06b78e295038c0af39f617 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
@@ -50,26 +50,18 @@ class AutofillSectionContainerTest : public ui::CocoaTest {
TEST_VIEW(AutofillSectionContainerTest, [container_ view])
TEST_F(AutofillSectionContainerTest, HasSubviews) {
- ASSERT_EQ(2U, [[[container_ view] subviews] count]);
-
bool hasLayoutView = false;
bool hasTextField = false;
bool hasSuggestButton = false;
- NSView* sectionView = nil;
+ ASSERT_EQ(3U, [[[container_ view] subviews] count]);
for (NSView* view in [[container_ view] subviews]) {
- if ([view isKindOfClass:[MenuButton class]])
- hasSuggestButton = true;
- else
- sectionView = view;
- }
-
- ASSERT_EQ(2U, [[sectionView subviews] count]);
- for (NSView* view in [sectionView subviews]) {
if ([view isKindOfClass:[NSTextField class]]) {
hasTextField = true;
} else if ([view isKindOfClass:[LayoutView class]]) {
hasLayoutView = true;
+ } else if ([view isKindOfClass:[MenuButton class]]) {
Robert Sesek 2013/05/24 20:49:23 nit: else if spacing
groby-ooo-7-16 2013/05/24 23:53:35 Done.
+ hasSuggestButton = true;
}
}

Powered by Google App Engine
This is Rietveld 408576698