[rAC] Allow sub-views to trigger layout reflow.

chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/memory/scoped_nsobject.h"
 #include "chrome/browser/ui/chrome_style.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_button.h"
 #include "chrome/browser/ui/chrome_style.h"
 #include "chrome/browser/ui/chrome_style.h"
 #import "chrome/browser/ui/cocoa/autofill/autofill_account_chooser.h"
 #import "chrome/browser/ui/cocoa/autofill/autofill_details_container.h"
 #import "chrome/browser/ui/cocoa/autofill/autofill_main_container.h"
 #import "chrome/browser/ui/cocoa/autofill/autofill_section_container.h"
 #import "chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h"
 #include "ui/base/cocoa/window_size_constants.h"
 
+namespace {
+
+const CGFloat kAccountChooserHeight = 20.0;
+const CGFloat kRelatedControlVerticalSpacing = 8.0;
+
+}  // namespace;
+
 namespace autofill {
 
 // static
 AutofillDialogView* AutofillDialogView::Create(
     AutofillDialogController* controller) {
   return new AutofillDialogCocoa(controller);
 }
 
 AutofillDialogCocoa::AutofillDialogCocoa(AutofillDialogController* controller)
     : controller_(controller) {
@@ skipping 104 matching lines @@
         [[AutofillSignInContainer alloc]
             initWithController:autofillDialog->controller()]);
     [[signInContainer_ view] setHidden:YES];
 
     NSRect clientRect = [[mainContainer_ view] frame];
     clientRect.origin = NSMakePoint(chrome_style::kClientBottomPadding,
                                     chrome_style::kHorizontalPadding);
     [[mainContainer_ view] setFrame:clientRect];
     [[signInContainer_ view] setFrame:clientRect];
 
-    const CGFloat kAccountChooserHeight = 20.0;
     NSRect headerRect = clientRect;
     headerRect.size.height = kAccountChooserHeight;
     headerRect.origin.y = NSMaxY(clientRect);
     accountChooser_.reset([[AutofillAccountChooser alloc]
                               initWithFrame:headerRect
                                  controller:autofillDialog->controller()]);
     [[[self window] contentView] setSubviews:
         @[accountChooser_, [mainContainer_ view], [signInContainer_ view]]];
 
     NSRect contentRect = clientRect;
     contentRect.origin = NSMakePoint(0, 0);
     contentRect.size.width += 2 * chrome_style::kHorizontalPadding;
     contentRect.size.height += NSHeight(headerRect) +
                                chrome_style::kClientBottomPadding +
                                chrome_style::kTitleTopPadding;
-    [[[self window] contentView] setFrame:contentRect];
-    NSRect frame = [[self window] frameRectForContentRect:contentRect];
-    [[self window] setFrame:frame display:YES];
-
-    [accountChooser_
-        setAutoresizingMask:(NSViewWidthSizable | NSViewMinYMargin)];
+    [self performLayout];
   }
   return self;
 }
 
+- (void)requestRelayout {
+  [self performLayout];
+}
+
+- (NSSize)preferredSize {
+  NSSize contentSize;
+  if ([[signInContainer_ view] isHidden]) {
+    contentSize = [mainContainer_ preferredSize];
+  } else {
+    // TODO(groby): Currently, keep size identical to main container.
+    // Change to allow autoresize of web contents.
+    contentSize = [mainContainer_ preferredSize];

[Robert Sesek, 2013/05/24 20:49:23]

These two if-branches are the same.

[groby-ooo-7-16, 2013/05/24 23:53:35]

Done.

+  }
+
+  NSSize headerSize = NSMakeSize(contentSize.width, kAccountChooserHeight);
+  NSSize size = NSMakeSize(
+      std::max(contentSize.width, headerSize.width),
+      contentSize.height + headerSize.height + kRelatedControlVerticalSpacing);
+  size.width += 2 * chrome_style::kHorizontalPadding;
+  size.height += chrome_style::kClientBottomPadding +
+                 chrome_style::kTitleTopPadding;
+  return size;
+}
+
+- (void)performLayout {
+  // Don't animate when we first show the window.
+  BOOL shouldAnimate =
+    !NSEqualRects(ui::kWindowSizeDeterminedLater, [[self window] frame]);

[Robert Sesek, 2013/05/24 20:49:23]

nit: continuation -> indent 4

[groby-ooo-7-16, 2013/05/24 23:53:35]

Done.

+
+  NSRect contentRect = NSZeroRect;
+  contentRect.size = [self preferredSize];
+  NSRect clientRect = NSInsetRect(
+      contentRect, chrome_style::kHorizontalPadding, 0);
+  clientRect.origin.y += chrome_style::kClientBottomPadding;
+  clientRect.size.height -= chrome_style::kTitleTopPadding +
+                            chrome_style::kClientBottomPadding;
+
+  NSRect headerRect, mainRect;
+  NSDivideRect(clientRect, &headerRect, &mainRect,
+               kAccountChooserHeight, NSMaxYEdge);
+
+  [accountChooser_ setFrame:headerRect];
+  if ([[signInContainer_ view] isHidden]) {
+    [[mainContainer_ view] setFrame:mainRect];
+    [mainContainer_ performLayout];
+  } else {
+    [[signInContainer_ view] setFrame:mainRect];
+  }
+
+  NSRect frameRect = [[self window] frameRectForContentRect:contentRect];
+  [[self window] setFrame:frameRect display:YES animate:shouldAnimate];
+}
+
 - (IBAction)accept:(id)sender {
   // TODO(groby): Validation goes here.
   autofillDialog_->controller()->OnAccept();
 }
 
 - (IBAction)cancel:(id)sender {
   // TODO(groby): Validation goes here.
   autofillDialog_->controller()->OnCancel();
   autofillDialog_->Hide();
 }
 
 - (void)updateAccountChooser {
   [accountChooser_ update];
 }
 
 - (content::NavigationController*)showSignIn {
   [signInContainer_ loadSignInPage];
   [[mainContainer_ view] setHidden:YES];
   [[signInContainer_ view] setHidden:NO];
+  [self performLayout];
 
   return [signInContainer_ navigationController];
 }
 
 - (void)getInputs:(autofill::DetailOutputMap*)output
        forSection:(autofill::DialogSection)section {
   [[mainContainer_ sectionForId:section] getInputs:output];
 }
 
 - (void)hideSignIn {
   [[signInContainer_ view] setHidden:YES];
   [[mainContainer_ view] setHidden:NO];
+  [self performLayout];
 }
 
 - (void)modelChanged {
   [mainContainer_ modelChanged];
 }
 
 @end