[rAC] Allow sub-views to trigger layout reflow.

chrome/browser/ui/cocoa/autofill/autofill_details_container.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_details_container.h"
 
+#include <algorithm>
+
 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
 #import "chrome/browser/ui/cocoa/autofill/autofill_section_container.h"
 
 @implementation AutofillDetailsContainer
 
 - (id)initWithController:(autofill::AutofillDialogController*)controller {
   if (self = [super init]) {
     controller_ = controller;
   }
   return self;
 }
 
 - (void)addSection:(autofill::DialogSection)section {
   scoped_nsobject<AutofillSectionContainer> sectionContainer(
       [[AutofillSectionContainer alloc] initWithController:controller_
                                                 forSection:section]);
   [details_ addObject:sectionContainer];
 }
 
 - (void)loadView {
   details_.reset([[NSMutableArray alloc] init]);
 
   [self addSection:autofill::SECTION_EMAIL];
   [self addSection:autofill::SECTION_CC];
   [self addSection:autofill::SECTION_BILLING];
   // TODO(groby): Add SECTION_CC_BILLING once toggling is enabled.
   [self addSection:autofill::SECTION_SHIPPING];
 
   [self setView:[[NSView alloc] init]];
+  for (AutofillSectionContainer* container in details_.get())
+    [[self view] addSubview:[container view]];
 
+  [self performLayout];
+}
+
+- (NSSize)preferredSize {
+  NSSize size = NSMakeSize(0, 0);
+
+  for (AutofillSectionContainer* container in
+       details_.get()) {

[Robert Sesek, 2013/05/24 20:49:23]

nit: indent 4 spaces for continuation

[groby-ooo-7-16, 2013/05/24 23:53:35]

Done.

+    NSSize containerSize = [container preferredSize];
+    size.height += containerSize.height;
+    size.width = std::max(containerSize.width, size.width);
+  }
+  return size;
+}
+
+- (void)performLayout {
   NSRect rect = NSZeroRect;
   for (AutofillSectionContainer* container in
       [details_ reverseObjectEnumerator]) {
+    [container performLayout];
     [[container view] setFrameOrigin:NSMakePoint(0, NSMaxY(rect))];
     rect = NSUnionRect(rect, [[container view] frame]);
-    [[self view] addSubview:[container view]];
   }
-  [[self view] setFrame:rect];
+
+  [[self view] setFrameSize:[self preferredSize]];
 }
 
 - (AutofillSectionContainer*)sectionForId:(autofill::DialogSection)section {
   for (AutofillSectionContainer* details in details_.get()) {
     if ([details section] == section)
       return details;
   }
   return nil;
 }
 
 - (void)modelChanged {
   for (AutofillSectionContainer* details in details_.get())
     [details modelChanged];
 }
 
 @end