runtime/vm/debugger.cc - Issue 1564493002: Make Scanner::kNoSourcePos be a true sentinel value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.cc

Issue 1564493002: Make Scanner::kNoSourcePos be a true sentinel value (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/debugger.cc

diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc

index 9ba75da4998f3b3040828641be698d7ac63a6cf9..39dc8a8e863e2a2a3f0f892e2226eefc068a6e47 100644

--- a/runtime/vm/debugger.cc

+++ b/runtime/vm/debugger.cc

@@ -93,8 +93,8 @@ BreakpointLocation::BreakpointLocation(const String& url,

intptr_t requested_column_number)

: script_(Script::null()),

url_(url.raw()),

- token_pos_(-1),

- end_token_pos_(-1),

+ token_pos_(Scanner::kNoSourcePos),

+ end_token_pos_(Scanner::kNoSourcePos),

is_resolved_(false),

next_(NULL),

conditions_(NULL),

@@ -239,7 +239,7 @@ ActivationFrame::ActivationFrame(

code_(Code::ZoneHandle(code.raw())),

function_(Function::ZoneHandle(code.function())),

token_pos_initialized_(false),

- token_pos_(-1),

+ token_pos_(Scanner::kNoSourcePos),

try_index_(-1),

line_number_(-1),

column_number_(-1),

« no previous file with comments | « runtime/vm/code_generator_test.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »