runtime/vm/flow_graph_compiler_mips.cc - Issue 1564493002: Make Scanner::kNoSourcePos be a true sentinel value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 1564493002: Make Scanner::kNoSourcePos be a true sentinel value (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_mips.cc

diff --git a/runtime/vm/flow_graph_compiler_mips.cc b/runtime/vm/flow_graph_compiler_mips.cc

index 55a3dfc36ced4f2dddcc4e58b9667c188bd7cb48..3c7f8e99c6584817d4e622dc90a8d114561e0001 100644

--- a/runtime/vm/flow_graph_compiler_mips.cc

+++ b/runtime/vm/flow_graph_compiler_mips.cc

@@ -668,7 +668,7 @@ void FlowGraphCompiler::GenerateAssertAssignable(intptr_t token_pos,

const String& dst_name,

LocationSummary* locs) {

__ Comment("AssertAssignable");

- ASSERT(token_pos >= 0);

+ ASSERT(Scanner::ValidSourcePosition(token_pos));

ASSERT(!dst_type.IsNull());

ASSERT(dst_type.IsFinalized());

// Assignable check is skipped in FlowGraphBuilder, not here.