runtime/vm/ast.h - Issue 1564493002: Make Scanner::kNoSourcePos be a true sentinel value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/ast.h

Issue 1564493002: Make Scanner::kNoSourcePos be a true sentinel value (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/ast.h

diff --git a/runtime/vm/ast.h b/runtime/vm/ast.h

index 0e9b68c3107aa8dd5828523affb6a34b24515aba..ba41f40810c0d4495c69afed341ce276383b375f 100644

--- a/runtime/vm/ast.h

+++ b/runtime/vm/ast.h

@@ -99,7 +99,7 @@ class AstNode : public ZoneAllocated {

public:

explicit AstNode(intptr_t token_pos)

: token_pos_(token_pos) {

- ASSERT(token_pos_ >= 0);

+ ASSERT(Scanner::ValidSourcePosition(token_pos_));

}

virtual ~AstNode() { }

« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | runtime/vm/object.cc » ('J')