Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 1564453002: Remove some dead PDF code. (try 2) (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some dead PDF code. (try 2) Committed: https://crrev.com/6f035b7c8260e85f7e14bf53307b8d1dc0406d1b Cr-Commit-Position: refs/heads/master@{#367695}

Patch Set 1 : previous try - https://codereview.chromium.org/1552833003/ #

Patch Set 2 : try 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -50 lines) Patch
M pdf/pdf_engine.h View 3 chunks +0 lines, -5 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 2 chunks +0 lines, -7 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 5 chunks +2 lines, -38 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
4 years, 11 months ago (2016-01-05 20:08:50 UTC) #2
raymes
lgtm
4 years, 11 months ago (2016-01-05 23:26:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564453002/20001
4 years, 11 months ago (2016-01-05 23:30:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 23:42:13 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 23:43:53 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f035b7c8260e85f7e14bf53307b8d1dc0406d1b
Cr-Commit-Position: refs/heads/master@{#367695}

Powered by Google App Engine
This is Rietveld 408576698