Fix x64 android_tools target compile failure.

Fix x64 android_tools target compile failure.

Few functions were unused on x86 causing unused function errors.

BUG=574494
Committed: https://crrev.com/80090bd83b13c23c0f1c75d16e5f878da719b30a
Cr-Commit-Position: refs/heads/master@{#367657}

[Kibeom Kim (inactive), 2016-01-05 19:38:41]

kkimlabs@chromium.org changed reviewers:
+ thakis@chromium.org

[Kibeom Kim (inactive), 2016-01-05 19:40:12]

The CQ bit was checked by kkimlabs@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-05 19:40:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564443002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564443002/1

[Nico, 2016-01-05 19:42:36]

Thank you!

https://codereview.chromium.org/1564443002/diff/1/build/android/ndk.gyp
File build/android/ndk.gyp (right):

https://codereview.chromium.org/1564443002/diff/1/build/android/ndk.gyp#newco...
build/android/ndk.gyp:20: '-Wno-unused-function',
Can you file an NDK bug and point to it here?

https://codereview.chromium.org/1564443002/diff/1/build/secondary/third_party...
File build/secondary/third_party/android_tools/BUILD.gn (right):

https://codereview.chromium.org/1564443002/diff/1/build/secondary/third_party...
build/secondary/third_party/android_tools/BUILD.gn:9: cflags = [
"-Wno-unused-function" ]
That's not correct, for two reasons:

1. This is listed as a public_configs below and is applied to everything
depending on this target.

2. cflags in configs are applied in config order in gn. Since cpu_features below
appends no_chromium_code after this is set in public_configs, I think the -Wall
in no_chromium_code will be ordered after -Wno-unused-function, and in
"-Wno-unused-function -Wall" the later Wall wins over the earlier
Wno-unused-function.

You need to make a new

config("cpu_features_warnings") {
  if (is_clang) {
    cflags = [ "-Wno-unused-function" ]
  }
}

and then add that to configs in cpu_features (with a comment like
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/zlib/B...)

[Kibeom Kim (inactive), 2016-01-05 20:41:22]

https://codereview.chromium.org/1564443002/diff/1/build/android/ndk.gyp
File build/android/ndk.gyp (right):

https://codereview.chromium.org/1564443002/diff/1/build/android/ndk.gyp#newco...
build/android/ndk.gyp:20: '-Wno-unused-function',
On 2016/01/05 19:42:35, Nico wrote:
> Can you file an NDK bug and point to it here?

Done.

https://codereview.chromium.org/1564443002/diff/1/build/secondary/third_party...
File build/secondary/third_party/android_tools/BUILD.gn (right):

https://codereview.chromium.org/1564443002/diff/1/build/secondary/third_party...
build/secondary/third_party/android_tools/BUILD.gn:9: cflags = [
"-Wno-unused-function" ]
On 2016/01/05 19:42:36, Nico wrote:
> That's not correct, for two reasons:
> 
> 1. This is listed as a public_configs below and is applied to everything
> depending on this target.
> 
> 2. cflags in configs are applied in config order in gn. Since cpu_features
below
> appends no_chromium_code after this is set in public_configs, I think the
-Wall
> in no_chromium_code will be ordered after -Wno-unused-function, and in
> "-Wno-unused-function -Wall" the later Wall wins over the earlier
> Wno-unused-function.
> 
> You need to make a new
> 
> config("cpu_features_warnings") {
>   if (is_clang) {
>     cflags = [ "-Wno-unused-function" ]
>   }
> }
> 
> and then add that to configs in cpu_features (with a comment like
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/zlib/B...)

Done.

[Kibeom Kim (inactive), 2016-01-05 20:41:44]

The CQ bit was checked by kkimlabs@chromium.org to run a CQ dry run

[Nico, 2016-01-05 20:42:41]

lgtm, thanks!

[Kibeom Kim (inactive), 2016-01-05 20:43:40]

The CQ bit was unchecked by kkimlabs@chromium.org

[Kibeom Kim (inactive), 2016-01-05 20:43:44]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2016-01-05 20:46:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564443002/20001

[commit-bot: I haz the power, 2016-01-05 21:57:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-05 21:58:41]

Description was changed from

==========
Fix x64 android_tools target compile failure.

Few functions were unused on x86 causing unused function errors.

BUG=574494
==========

to

==========
Fix x64 android_tools target compile failure.

Few functions were unused on x86 causing unused function errors.

BUG=574494

Committed: https://crrev.com/80090bd83b13c23c0f1c75d16e5f878da719b30a
Cr-Commit-Position: refs/heads/master@{#367657}
==========

[commit-bot: I haz the power, 2016-01-05 21:58:41]

Patchset 2 (id:??) landed as
https://crrev.com/80090bd83b13c23c0f1c75d16e5f878da719b30a
Cr-Commit-Position: refs/heads/master@{#367657}