Issue 1564423002: Copy all fields of NullCheck

Issue 1564423002: Copy all fields of NullCheck (Closed)

Created:
4 years, 11 months ago by sra1

Modified:
4 years, 11 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Copy all fields of NullCheck Failing to copy the condition and selector lead to an inlined check that should have been if (typeof v0 !== "number") return v0.$add; becoming v0.toString; R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/1c1a0196f331d2fd4dbc1ef48139a82740378e2e

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -14 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View	3 chunks	+23 lines, -10 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/inline.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 7 (3 generated)

sra1

The comment in codegen.dart explains why I added the useSelector field. It is handy to ...

4 years, 11 months ago (2016-01-08 18:12:16 UTC) #2

sra1

4 years, 11 months ago (2016-01-08 19:14:22 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1c1a0196f331d2fd4dbc1ef48139a82740378e2e (presubmit successful).