presubmit_canned_checks.py - Issue 1564403003: Remove readability/inheritance from the lint blacklist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 1564403003: Remove readability/inheritance from the lint blacklist (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py

index 7a6f8b57f7e2cb48beda6711656e5c5b72eefe06..b18e18f4e800b8021185caef7646a4ad0de88380 100644

--- a/presubmit_canned_checks.py

+++ b/presubmit_canned_checks.py

@@ -16,8 +16,6 @@ _HERE = _os.path.dirname(_os.path.abspath(__file__))

# - runtime/int : Can be fixed long term; volume of errors too high

# - runtime/virtual : Broken now, but can be fixed in the future?

# - whitespace/braces : We have a lot of explicit scoping in chrome code.

-# - readability/inheritance : Temporary, while the OVERRIDE and FINAL fixup

-# is in progress.

DEFAULT_LINT_FILTERS = [

'-build/include',

'-build/include_order',

@@ -26,7 +24,6 @@ DEFAULT_LINT_FILTERS = [

'-runtime/int',

'-runtime/virtual',

'-whitespace/braces',

- '-readability/inheritance'

]

### Description checks

« no previous file with comments | « no previous file | no next file » | no next file with comments »