Issue 1564403002: New apprtc zip with node_modules removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1564403002: New apprtc zip with node_modules removed. (Closed)

Created:
4 years, 11 months ago by phoglund_chromium

Modified:
4 years, 11 months ago

Reviewers:
kjellander_chromium

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS@master

Target Ref:
refs/heads/master

Project:
chromium_deps

Visibility:
Public.

More Reviews

Description

New apprtc zip with node_modules removed. This should fix win bots blowing up on unzip. BUG=569494 TBR=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/webrtc/webrtc.DEPS/+/307aa8cc94086f834f6789dc4827b9582001701d

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	prebuilt_apprtc.zip.sha1	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

phoglund_chromium

Committed patchset #1 (id:1) manually as 307aa8cc94086f834f6789dc4827b9582001701d (presubmit successful).

4 years, 11 months ago (2016-01-08 16:40:45 UTC) #4

kjellander_chromium

4 years, 11 months ago (2016-01-08 18:27:39 UTC) #5

Message was sent while issue was closed.

lgtm

Does this mean the zip-creation instructions in the previous CL needs to be
updated? I guess we should put those into a README.md file in here instead.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages