Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1564393003: Fixing asm validation of switch statements. (Closed)

Created:
4 years, 11 months ago by bradnelson
Modified:
4 years, 11 months ago
Reviewers:
aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fixing asm validation of switch statements. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/6932124c18e377b990d05c3cbf902de8286ef6d8 Cr-Commit-Position: refs/heads/master@{#33216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -9 lines) Patch
M src/typing-asm.cc View 2 chunks +15 lines, -9 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
bradn
4 years, 11 months ago (2016-01-09 00:27:44 UTC) #2
aseemgarg
lgtm
4 years, 11 months ago (2016-01-09 01:01:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564393003/1
4 years, 11 months ago (2016-01-09 01:04:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9585)
4 years, 11 months ago (2016-01-09 01:06:49 UTC) #7
bradn
+titzer
4 years, 11 months ago (2016-01-09 01:08:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564393003/1
4 years, 11 months ago (2016-01-11 19:49:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9627)
4 years, 11 months ago (2016-01-11 19:52:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564393003/1
4 years, 11 months ago (2016-01-11 20:21:16 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 20:36:29 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 20:36:58 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6932124c18e377b990d05c3cbf902de8286ef6d8
Cr-Commit-Position: refs/heads/master@{#33216}

Powered by Google App Engine
This is Rietveld 408576698