Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1564363005: [DevTools] Device Mode polish. (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Device Mode polish. - removed blueprints; - reworked zoom; - allowed sticky height (empty value); - resizing on toggling rulers; - layout adjustments; - fixed wrong values in options menu. BUG=540864 Committed: https://crrev.com/22d8f1d01fc461524258b9856f326697f9b84b0c Cr-Commit-Position: refs/heads/master@{#368686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -159 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 9 chunks +25 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 18 chunks +57 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/deviceModeView.css View 2 chunks +1 line, -51 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js View 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 3 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dgozman
Take a look please.
4 years, 11 months ago (2016-01-09 02:53:42 UTC) #3
pfeldman
lgtm
4 years, 11 months ago (2016-01-11 19:47:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564363005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564363005/1
4 years, 11 months ago (2016-01-11 19:55:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 22:08:46 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22d8f1d01fc461524258b9856f326697f9b84b0c Cr-Commit-Position: refs/heads/master@{#368686}
4 years, 11 months ago (2016-01-11 22:10:10 UTC) #10
pfeldman
4 years, 11 months ago (2016-01-12 19:37:17 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1581763002/ by pfeldman@chromium.org.

The reason for reverting is: Breaks responsive design mode..

Powered by Google App Engine
This is Rietveld 408576698