Fix for temporaries in parameter initializers

Fix for temporaries in parameter initializers

This patch introduces a mechanism for changing the scope of temporary
variables, which is necessary for rewriting arrow parameter
initializers.

It also fixes a potential bug in AstExpressionVisitor, which did not
visit the automatically generated members of ForEachStatement.

Fixes test/mjsunit/harmony/regress/regress-4658.js

R=rossberg@chromium.org
BUG=v8:4658
LOG=N

Committed: https://crrev.com/0406fa2237acb05af24a9e264d7d451f5901834f
Cr-Commit-Position: refs/heads/master@{#33183}

[nickie, 2016-01-08 14:21:48]

On 2016/01/08 14:20:07, nickie wrote:

This patch contains elements of this:
https://codereview.chromium.org/1564083002/#ps1

[rossberg, 2016-01-08 14:59:42]

lgtm

[nickie, 2016-01-08 15:02:15]

The CQ bit was checked by nikolaos@chromium.org

[commit-bot: I haz the power, 2016-01-08 15:02:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564343002/1

[commit-bot: I haz the power, 2016-01-08 15:21:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 15:21:09]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9565)

[nickie, 2016-01-08 15:31:31]

Description was changed from

==========
Fix for temporaries in parameter initializers

This patch introduces a mechanism for changing the scope of temporary
variables, which is necessary for rewriting arrow parameter
initializers.

It also fixes a potential bug in AstExpressionVisitor, which did not
visit the automatically generated members of ForEachStatement.

Fixes test/mjsunit/harmony/regress/regress-4658.js

R=rossberg@chromium.org
BUG=v8:4658
==========

to

==========
Fix for temporaries in parameter initializers

This patch introduces a mechanism for changing the scope of temporary
variables, which is necessary for rewriting arrow parameter
initializers.

It also fixes a potential bug in AstExpressionVisitor, which did not
visit the automatically generated members of ForEachStatement.

Fixes test/mjsunit/harmony/regress/regress-4658.js

R=rossberg@chromium.org
BUG=v8:4658
LOG=N
==========

[nickie, 2016-01-08 15:31:37]

The CQ bit was checked by nikolaos@chromium.org

[commit-bot: I haz the power, 2016-01-08 15:31:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1564343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1564343002/1

[commit-bot: I haz the power, 2016-01-08 15:43:39]

Description was changed from

==========
Fix for temporaries in parameter initializers

This patch introduces a mechanism for changing the scope of temporary
variables, which is necessary for rewriting arrow parameter
initializers.

It also fixes a potential bug in AstExpressionVisitor, which did not
visit the automatically generated members of ForEachStatement.

Fixes test/mjsunit/harmony/regress/regress-4658.js

R=rossberg@chromium.org
BUG=v8:4658
LOG=N
==========

to

==========
Fix for temporaries in parameter initializers

This patch introduces a mechanism for changing the scope of temporary
variables, which is necessary for rewriting arrow parameter
initializers.

It also fixes a potential bug in AstExpressionVisitor, which did not
visit the automatically generated members of ForEachStatement.

Fixes test/mjsunit/harmony/regress/regress-4658.js

R=rossberg@chromium.org
BUG=v8:4658
LOG=N
==========

[commit-bot: I haz the power, 2016-01-08 15:43:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-08 15:44:32]

Description was changed from

==========
Fix for temporaries in parameter initializers

This patch introduces a mechanism for changing the scope of temporary
variables, which is necessary for rewriting arrow parameter
initializers.

It also fixes a potential bug in AstExpressionVisitor, which did not
visit the automatically generated members of ForEachStatement.

Fixes test/mjsunit/harmony/regress/regress-4658.js

R=rossberg@chromium.org
BUG=v8:4658
LOG=N
==========

to

==========
Fix for temporaries in parameter initializers

This patch introduces a mechanism for changing the scope of temporary
variables, which is necessary for rewriting arrow parameter
initializers.

It also fixes a potential bug in AstExpressionVisitor, which did not
visit the automatically generated members of ForEachStatement.

Fixes test/mjsunit/harmony/regress/regress-4658.js

R=rossberg@chromium.org
BUG=v8:4658
LOG=N

Committed: https://crrev.com/0406fa2237acb05af24a9e264d7d451f5901834f
Cr-Commit-Position: refs/heads/master@{#33183}
==========

[commit-bot: I haz the power, 2016-01-08 15:44:33]

Patchset 1 (id:??) landed as
https://crrev.com/0406fa2237acb05af24a9e264d7d451f5901834f
Cr-Commit-Position: refs/heads/master@{#33183}