Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issue 1564323002: Fix std::enable_if<> conversion bug. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix std::enable_if<> conversion bug. after r367242 - "::type" not "::Type". R=haraken BUG=554293 Committed: https://crrev.com/e1f56e50a1e7b46691bf09436c5238085cf990ca Cr-Commit-Position: refs/heads/master@{#368319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/wtf/LeakAnnotations.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
sof
please take a look.
4 years, 11 months ago (2016-01-08 10:58:35 UTC) #2
sof
(takes care of the LSan leaks.)
4 years, 11 months ago (2016-01-08 10:58:53 UTC) #3
haraken
LGTM
4 years, 11 months ago (2016-01-08 11:09:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564323002/1
4 years, 11 months ago (2016-01-08 12:06:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 13:22:15 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 13:23:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1f56e50a1e7b46691bf09436c5238085cf990ca
Cr-Commit-Position: refs/heads/master@{#368319}

Powered by Google App Engine
This is Rietveld 408576698