Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1564313003: [wasm] Fix validation error for missing return statement in asm.js module. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix validation error for missing return statement in asm.js module. R=mstarzinger@chromium.org,bradnelson@chromium.org LOG=Y BUG=chromium:575364 Committed: https://crrev.com/cad2294e420ebeb64288d5e45e7d52024c9914fa Cr-Commit-Position: refs/heads/master@{#33175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/typing-asm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-575364.js View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
titzer
4 years, 11 months ago (2016-01-08 12:06:29 UTC) #1
Michael Starzinger
LGTM.
4 years, 11 months ago (2016-01-08 12:09:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564313003/1
4 years, 11 months ago (2016-01-08 12:15:18 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9548)
4 years, 11 months ago (2016-01-08 12:28:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564313003/1
4 years, 11 months ago (2016-01-08 12:45:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 12:49:52 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cad2294e420ebeb64288d5e45e7d52024c9914fa Cr-Commit-Position: refs/heads/master@{#33175}
4 years, 11 months ago (2016-01-08 12:50:13 UTC) #13
bradn
4 years, 11 months ago (2016-01-08 18:09:41 UTC) #15
Message was sent while issue was closed.
lgtm, thanks for fixing!

Powered by Google App Engine
This is Rietveld 408576698