Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 15643003: Fix script error in android layout tests (Closed)

Created:
7 years, 7 months ago by kangil_
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix script error in android layout tests Script error(AttributeError: 'ChromiumAndroidDriver' object has no attribute '_cmd_line') happens when running android layout tests. So fix it. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
kangil_
Review please?
7 years, 7 months ago (2013-05-24 10:57:35 UTC) #1
Peter Beverloo
erps, thanks! lgtm
7 years, 7 months ago (2013-05-24 15:46:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/15643003/1
7 years, 7 months ago (2013-05-25 05:08:16 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10248
7 years, 7 months ago (2013-05-25 05:56:20 UTC) #4
kangil_
Hit commit again please? Thx! :)
7 years, 7 months ago (2013-05-25 08:39:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/15643003/1
7 years, 7 months ago (2013-05-25 09:19:35 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10252
7 years, 7 months ago (2013-05-25 10:01:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/15643003/1
7 years, 7 months ago (2013-05-25 10:03:10 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10257
7 years, 7 months ago (2013-05-25 10:46:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/15643003/1
7 years, 7 months ago (2013-05-25 18:13:03 UTC) #10
commit-bot: I haz the power
7 years, 7 months ago (2013-05-25 18:13:16 UTC) #11
Message was sent while issue was closed.
Change committed as 151155

Powered by Google App Engine
This is Rietveld 408576698