Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1564233002: test+bench new swizzle SkOpts (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : year #

Patch Set 3 : const #

Patch Set 4 : nah, that is dumb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
A bench/SwizzleBench.cpp View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
M tests/SwizzlerTest.cpp View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564233002/20001
4 years, 11 months ago (2016-01-08 01:27:01 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/4411)
4 years, 11 months ago (2016-01-08 01:28:21 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564233002/40001
4 years, 11 months ago (2016-01-08 01:29:30 UTC) #7
mtklein_C
4 years, 11 months ago (2016-01-08 01:40:35 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564233002/60001
4 years, 11 months ago (2016-01-08 01:46:16 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 02:04:05 UTC) #13
msarett
LGTM
4 years, 11 months ago (2016-01-08 13:38:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564233002/60001
4 years, 11 months ago (2016-01-08 14:32:22 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 14:32:54 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/55c86abedc7dcc76f5f04a256e46bb3bb065b2cb

Powered by Google App Engine
This is Rietveld 408576698