Issue 156423005: Move ParseRegexpLiteral to ParserBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 156423005: Move ParseRegexpLiteral to ParserBase. (Closed)

Created:
6 years, 10 months ago by marja

Modified:
6 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move ParseRegexpLiteral to ParserBase. R=ulan@chromium.org BUG=v8:3126 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19273

Patch Set 2 : Code review (ulan) #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -57 lines)			Patch
M	src/parser.h	View		5 chunks	+12 lines, -12 lines	0 comments	Download
M	src/parser.cc	View	1	3 chunks	+26 lines, -20 lines	0 comments	Download
M	src/preparser.h	View		7 chunks	+45 lines, -3 lines	0 comments	Download
M	src/preparser.cc	View		2 chunks	+5 lines, -22 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

lgtm https://codereview.chromium.org/156423005/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/156423005/diff/1/src/parser.cc#newcode627 src/parser.cc:627: ->NewRegExpLiteral(js_pattern, js_flags, literal_index, pos); Please break the line ...

6 years, 10 months ago (2014-02-11 11:44:40 UTC) #1

marja

Thanks for review! https://codereview.chromium.org/156423005/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/156423005/diff/1/src/parser.cc#newcode627 src/parser.cc:627: ->NewRegExpLiteral(js_pattern, js_flags, literal_index, pos); On 2014/02/11 ...

6 years, 10 months ago (2014-02-11 11:50:49 UTC) #2

marja

6 years, 10 months ago (2014-02-11 11:51:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r19273 (presubmit successful).

Expand Messages | Collapse Messages

Issue 156423005: Move ParseRegexpLiteral to ParserBase. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review (ulan) #

Messages