Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: runtime/vm/code_patcher.cc

Issue 156423004: Disable write protect mode temporarily until we have a fix for the random crashes (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/code_patcher.h" 5 #include "vm/code_patcher.h"
6 #include "vm/cpu.h" 6 #include "vm/cpu.h"
7 #include "vm/instructions.h" 7 #include "vm/instructions.h"
8 #include "vm/object.h" 8 #include "vm/object.h"
9 #include "vm/virtual_memory.h" 9 #include "vm/virtual_memory.h"
10 10
11 namespace dart { 11 namespace dart {
12 12
13 DEFINE_FLAG(bool, write_protect_code, true, "Write protect jitted code"); 13 DEFINE_FLAG(bool, write_protect_code, false, "Write protect jitted code");
14 14
15 15
16 WritableInstructionsScope::WritableInstructionsScope(uword address, 16 WritableInstructionsScope::WritableInstructionsScope(uword address,
17 intptr_t size) 17 intptr_t size)
18 : address_(address), size_(size) { 18 : address_(address), size_(size) {
19 if (FLAG_write_protect_code) { 19 if (FLAG_write_protect_code) {
20 bool status = 20 bool status =
21 VirtualMemory::Protect(reinterpret_cast<void*>(address), 21 VirtualMemory::Protect(reinterpret_cast<void*>(address),
22 size, 22 size,
23 VirtualMemory::kReadWrite); 23 VirtualMemory::kReadWrite);
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 const uword obj_start = code.GetPointerOffsetAt(i) + code.EntryPoint(); 131 const uword obj_start = code.GetPointerOffsetAt(i) + code.EntryPoint();
132 const uword obj_end = obj_start + kWordSize; 132 const uword obj_end = obj_start + kWordSize;
133 if ((obj_start < limit) && (obj_end > patch_addr)) { 133 if ((obj_start < limit) && (obj_end > patch_addr)) {
134 return false; 134 return false;
135 } 135 }
136 } 136 }
137 return true; 137 return true;
138 } 138 }
139 139
140 } // namespace dart 140 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698