third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js - Issue 1564113003: DevTools: merge uisourcecode's url-alike members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js

Issue 1564113003: DevTools: merge uisourcecode's url-alike members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js ('K') | « third_party/WebKit/Source/devtools/front_end/sources/EditingLocationHistoryManager.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js » ('j') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js b/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js

index 11df86efbac84c4606ce9391437b29b1b122ea8d..39002738d005491d41f206defdcbf705544cc22f 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js

@@ -80,7 +80,7 @@ WebInspector.FilteredUISourceCodeListDelegate.prototype = {

itemKeyAt: function(itemIndex)

{

- return this._uiSourceCodes[itemIndex].fullDisplayName();

+ return this._uiSourceCodes[itemIndex].url();

/**

@@ -101,7 +101,7 @@ WebInspector.FilteredUISourceCodeListDelegate.prototype = {

this._scorer = new WebInspector.FilePathScoreFunction(query);

}

- var path = uiSourceCode.fullDisplayName();

+ var path = uiSourceCode.url();

dgozman 2016/01/08 20:22:07 Not sure about this change - may surprise users.

pfeldman 2016/01/08 23:56:32 This only differs by the (index) modulus.

return score + 10 * this._scorer.score(path, null);