third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js - Issue 1564113003: DevTools: merge uisourcecode's url-alike members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js

Issue 1564113003: DevTools: merge uisourcecode's url-alike members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js ('K') | « third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ('k') | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js » ('j') | third_party/WebKit/Source/devtools/front_end/main/FrontendWebSocketAPI.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js b/third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js

index e103e2dcda86646ac410f21599b010396d1b2b65..826a2aa65581bf1c246b1846740ff32f7cb02d42 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js

@@ -139,7 +139,7 @@ WebInspector.MediaQueryInspector.prototype = {

var uiLocation = WebInspector.cssWorkspaceBinding.rawLocationToUILocation(locations[i]);

if (!uiLocation)

continue;

- var descriptor = String.sprintf("%s:%d:%d", uiLocation.uiSourceCode.uri(), uiLocation.lineNumber + 1, uiLocation.columnNumber + 1);

+ var descriptor = String.sprintf("%s:%d:%d", uiLocation.uiSourceCode.url(), uiLocation.lineNumber + 1, uiLocation.columnNumber + 1);

dgozman 2016/01/08 20:22:06 I think displayName suits better.

pfeldman 2016/01/08 23:56:32 This is location like in console, it should not us

uiLocations.set(descriptor, uiLocation);

}