Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

Issue 1564113003: DevTools: merge uisourcecode's url-alike members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.SidebarPane} 7 * @extends {WebInspector.SidebarPane}
8 * @param {!WebInspector.BreakpointManager} breakpointManager 8 * @param {!WebInspector.BreakpointManager} breakpointManager
9 * @param {function(!WebInspector.UISourceCode, number=, number=, boolean=)} sho wSourceLineDelegate 9 * @param {function(!WebInspector.UISourceCode, number=, number=, boolean=)} sho wSourceLineDelegate
10 */ 10 */
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 236
237 _compare: function(x, y) 237 _compare: function(x, y)
238 { 238 {
239 if (x !== y) 239 if (x !== y)
240 return x < y ? -1 : 1; 240 return x < y ? -1 : 1;
241 return 0; 241 return 0;
242 }, 242 },
243 243
244 _compareBreakpoints: function(b1, b2) 244 _compareBreakpoints: function(b1, b2)
245 { 245 {
246 return this._compare(b1.uiSourceCode.originURL(), b2.uiSourceCode.origin URL()) || this._compare(b1.lineNumber, b2.lineNumber); 246 return this._compare(b1.uiSourceCode.url(), b2.uiSourceCode.url()) || th is._compare(b1.lineNumber, b2.lineNumber);
247 }, 247 },
248 248
249 reset: function() 249 reset: function()
250 { 250 {
251 this.listElement.removeChildren(); 251 this.listElement.removeChildren();
252 if (this.listElement.parentElement) { 252 if (this.listElement.parentElement) {
253 this.element.removeChild(this.listElement); 253 this.element.removeChild(this.listElement);
254 this.element.appendChild(this.emptyElement); 254 this.element.appendChild(this.emptyElement);
255 } 255 }
256 this._items.clear(); 256 this._items.clear();
257 }, 257 },
258 258
259 __proto__: WebInspector.SidebarPane.prototype 259 __proto__: WebInspector.SidebarPane.prototype
260 } 260 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698