Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 1564113003: DevTools: merge uisourcecode's url-alike members. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 WebInspector.BreakpointManager.prototype = { 79 WebInspector.BreakpointManager.prototype = {
80 /** 80 /**
81 * @param {!WebInspector.UISourceCode} uiSourceCode 81 * @param {!WebInspector.UISourceCode} uiSourceCode
82 * @return {string} 82 * @return {string}
83 */ 83 */
84 _sourceFileId: function(uiSourceCode) 84 _sourceFileId: function(uiSourceCode)
85 { 85 {
86 var networkURL = this._networkMapping.networkURL(uiSourceCode) 86 var networkURL = this._networkMapping.networkURL(uiSourceCode)
87 if (!networkURL) 87 if (!networkURL)
88 return ""; 88 return "";
89 return uiSourceCode.uri(); 89 return uiSourceCode.url();
90 }, 90 },
91 91
92 /** 92 /**
93 * @override 93 * @override
94 * @param {!WebInspector.Target} target 94 * @param {!WebInspector.Target} target
95 */ 95 */
96 targetAdded: function(target) 96 targetAdded: function(target)
97 { 97 {
98 var debuggerModel = WebInspector.DebuggerModel.fromTarget(target); 98 var debuggerModel = WebInspector.DebuggerModel.fromTarget(target);
99 if (debuggerModel && !this._breakpointsActive) 99 if (debuggerModel && !this._breakpointsActive)
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 * @return {!WebInspector.BreakpointManager.Breakpoint} 236 * @return {!WebInspector.BreakpointManager.Breakpoint}
237 */ 237 */
238 _innerSetBreakpoint: function(uiSourceCode, lineNumber, columnNumber, condit ion, enabled) 238 _innerSetBreakpoint: function(uiSourceCode, lineNumber, columnNumber, condit ion, enabled)
239 { 239 {
240 var breakpoint = this.findBreakpoint(uiSourceCode, lineNumber, columnNum ber); 240 var breakpoint = this.findBreakpoint(uiSourceCode, lineNumber, columnNum ber);
241 if (breakpoint) { 241 if (breakpoint) {
242 breakpoint._updateState(condition, enabled); 242 breakpoint._updateState(condition, enabled);
243 return breakpoint; 243 return breakpoint;
244 } 244 }
245 var projectId = uiSourceCode.project().id(); 245 var projectId = uiSourceCode.project().id();
246 var path = uiSourceCode.path(); 246 var path = uiSourceCode.url();
247 var sourceFileId = this._sourceFileId(uiSourceCode); 247 var sourceFileId = this._sourceFileId(uiSourceCode);
248 breakpoint = new WebInspector.BreakpointManager.Breakpoint(this, project Id, path, sourceFileId, lineNumber, columnNumber, condition, enabled); 248 breakpoint = new WebInspector.BreakpointManager.Breakpoint(this, project Id, path, sourceFileId, lineNumber, columnNumber, condition, enabled);
249 if (!this._breakpointsForPrimaryUISourceCode.get(uiSourceCode)) 249 if (!this._breakpointsForPrimaryUISourceCode.get(uiSourceCode))
250 this._breakpointsForPrimaryUISourceCode.set(uiSourceCode, []); 250 this._breakpointsForPrimaryUISourceCode.set(uiSourceCode, []);
251 this._breakpointsForPrimaryUISourceCode.get(uiSourceCode).push(breakpoin t); 251 this._breakpointsForPrimaryUISourceCode.get(uiSourceCode).push(breakpoin t);
252 return breakpoint; 252 return breakpoint;
253 }, 253 },
254 254
255 /** 255 /**
256 * @param {!WebInspector.UISourceCode} uiSourceCode 256 * @param {!WebInspector.UISourceCode} uiSourceCode
(...skipping 825 matching lines...) Expand 10 before | Expand all | Expand 10 after
1082 { 1082 {
1083 this.sourceFileId = breakpoint._sourceFileId; 1083 this.sourceFileId = breakpoint._sourceFileId;
1084 this.lineNumber = breakpoint.lineNumber(); 1084 this.lineNumber = breakpoint.lineNumber();
1085 this.columnNumber = breakpoint.columnNumber(); 1085 this.columnNumber = breakpoint.columnNumber();
1086 this.condition = breakpoint.condition(); 1086 this.condition = breakpoint.condition();
1087 this.enabled = breakpoint.enabled(); 1087 this.enabled = breakpoint.enabled();
1088 } 1088 }
1089 1089
1090 /** @type {!WebInspector.BreakpointManager} */ 1090 /** @type {!WebInspector.BreakpointManager} */
1091 WebInspector.breakpointManager; 1091 WebInspector.breakpointManager;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698