Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1564053002: [wasm] Fix simple graph building tests by enabling all optional operators. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix simple graph building tests by enabling all optional operators. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/7334b263d2f2df67fdde7bfb21b934f8241ece8d Cr-Commit-Position: refs/heads/master@{#33161}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add CHECK_EQ for parameter sig count #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -39 lines) Patch
M test/cctest/wasm/test-run-wasm.cc View 1 3 chunks +46 lines, -39 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
titzer
4 years, 11 months ago (2016-01-07 12:25:36 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/1564053002/diff/1/test/cctest/wasm/test-run-wasm.cc File test/cctest/wasm/test-run-wasm.cc (right): https://codereview.chromium.org/1564053002/diff/1/test/cctest/wasm/test-run-wasm.cc#newcode2323 test/cctest/wasm/test-run-wasm.cc:2323: } else { suggestion: Would a DCHECK_EQ(2, sig->parameter_count()) ...
4 years, 11 months ago (2016-01-07 14:44:35 UTC) #2
titzer
On 2016/01/07 14:44:35, Michael Starzinger wrote: > LGTM. > > https://codereview.chromium.org/1564053002/diff/1/test/cctest/wasm/test-run-wasm.cc > File test/cctest/wasm/test-run-wasm.cc (right): ...
4 years, 11 months ago (2016-01-07 16:34:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564053002/20001
4 years, 11 months ago (2016-01-07 16:39:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-07 16:58:21 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 16:59:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7334b263d2f2df67fdde7bfb21b934f8241ece8d
Cr-Commit-Position: refs/heads/master@{#33161}

Powered by Google App Engine
This is Rietveld 408576698