Issue 1563983002: dart2js cps: Eliminate unary string concatenation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1563983002: dart2js cps: Eliminate unary string concatenation. (Closed)

Created:
4 years, 11 months ago by asgerf

Modified:
4 years, 11 months ago

Reviewers:
Kevin Millikin (Google), sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	tests/compiler/dart2js/js_backend_cps_ir_operators_test.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

A unit test is currently failing because the expected output does not match the actual ...

4 years, 11 months ago (2016-01-06 23:19:38 UTC) #2

asgerf

4 years, 11 months ago (2016-01-07 00:18:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
eadb59e4c191731444926888cbfa2172bb0984ed (presubmit successful).