Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1563923003: Revert of DM: add a pixel check to serialize (Closed)

Created:
4 years, 11 months ago by caryclark
Modified:
4 years, 11 months ago
Reviewers:
mtklein, mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of DM: add a pixel check to serialize (patchset #4 id:60001 of https://codereview.chromium.org/1561993003/ ) Reason for revert: breaks windows bots; additional windows specific failures need to be blacklisted Original issue's description: > DM: add a pixel check to serialize > > If we're running through serialize and then drawing into some raster target (e.g. serialize-8888 like we run on the bots), make sure the serialized version is identical to what we'd get if we just drew into the rest of the pipeline (i.e. 8888). > > Start by blacklisting all current failures. This at least prevents further regression. > > BUG=skia:4095 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1561993003 > > Committed: https://skia.googlesource.com/skia/+/6eb4e36a93ea695e7adb771ea9ac3326680a8e98 TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4095 Committed: https://skia.googlesource.com/skia/+/60c0a76738f21bc856d2e35367fc703845b728af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -958 lines) Patch
M dm/DMSrcSink.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
M tools/dm_flags.json View 12 chunks +5 lines, -917 lines 0 comments Download
M tools/dm_flags.py View 2 chunks +1 line, -23 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
caryclark
Created Revert of DM: add a pixel check to serialize
4 years, 11 months ago (2016-01-07 13:11:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563923003/1
4 years, 11 months ago (2016-01-07 13:12:03 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 13:12:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/60c0a76738f21bc856d2e35367fc703845b728af

Powered by Google App Engine
This is Rietveld 408576698