[es6] Handle function names in object and class literals

[es6] Handle function names in object and class literals

This required refactoring ParsePropertyDefinition to pass the parsed
string name as an out param, since ObjectLiteralProperty stores Smis
for Smi-representable property keys.

Computed properties are not yet handled in this patch.

BUG=v8:3699
LOG=n

Committed: https://crrev.com/2367abf02579dd2b0643927109bc6d74c502479f
Cr-Commit-Position: refs/heads/master@{#33141}

[adamk, 2016-01-06 20:35:52]

Description was changed from

==========
[es6] Handle function names in object and class literals

This required refactoring ParsePropertyDefinition to pass the parsed
string name as an out param, since ObjectLiteralProperty stores Smis
for Smi-representable property keys.

BUG=v8:3699
LOG=n
==========

to

==========
[es6] Handle function names in object and class literals

This required refactoring ParsePropertyDefinition to pass the parsed
string name as an out param, since ObjectLiteralProperty stores Smis
for Smi-representable property keys.

Computed properties are not yet handled in this patch.

BUG=v8:3699
LOG=n
==========

[adamk, 2016-01-06 20:36:02]

adamk@chromium.org changed reviewers:
+ littledan@chromium.org

[Dan Ehrenberg, 2016-01-06 21:25:39]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-01-06 21:25:39]

lgtm

https://codereview.chromium.org/1563923002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1563923002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:6536: if (property->is_computed_name()) return;
Optional: Add a failing test for this case?

https://codereview.chromium.org/1563923002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:6553: auto class_literal = value->AsClassLiteral();
DCHECK that it's a CONSTANT property?

[Dan Ehrenberg, 2016-01-06 21:25:42]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2016-01-06 21:26:25]

That was a mistaken click. I have a couple comments, but the big one is the
treatment of the __proto__ property. According to
http://tc39.github.io/ecma262/#sec-__proto__-property-names-in-object-initial...
, we should not name things __proto__ based on being object properties, but I'm
not sure if this patch follows that.

[Dan Ehrenberg, 2016-01-06 21:36:41]

On 2016/01/06 at 21:26:25, Dan Ehrenberg wrote:
> That was a mistaken click. I have a couple comments, but the big one is the
treatment of the __proto__ property. According to
http://tc39.github.io/ecma262/#sec-__proto__-property-names-in-object-initial...
, we should not name things __proto__ based on being object properties, but I'm
not sure if this patch follows that.

not lgtm

[adamk, 2016-01-06 21:53:03]

Good catch, __proto__ is now handled correctly.

https://codereview.chromium.org/1563923002/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1563923002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:6536: if (property->is_computed_name()) return;
On 2016/01/06 21:25:39, Dan Ehrenberg wrote:
> Optional: Add a failing test for this case?

Done. And this caught a bug for static class properties!

https://codereview.chromium.org/1563923002/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:6553: auto class_literal = value->AsClassLiteral();
On 2016/01/06 21:25:39, Dan Ehrenberg wrote:
> DCHECK that it's a CONSTANT property?

It's not, though. It's "COMPUTED". I've added a DCHECK for that.

[Dan Ehrenberg, 2016-01-06 22:09:30]

lgtm

[adamk, 2016-01-06 22:32:53]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-01-06 22:32:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1563923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1563923002/20001

[commit-bot: I haz the power, 2016-01-06 23:38:34]

Description was changed from

==========
[es6] Handle function names in object and class literals

This required refactoring ParsePropertyDefinition to pass the parsed
string name as an out param, since ObjectLiteralProperty stores Smis
for Smi-representable property keys.

Computed properties are not yet handled in this patch.

BUG=v8:3699
LOG=n
==========

to

==========
[es6] Handle function names in object and class literals

This required refactoring ParsePropertyDefinition to pass the parsed
string name as an out param, since ObjectLiteralProperty stores Smis
for Smi-representable property keys.

Computed properties are not yet handled in this patch.

BUG=v8:3699
LOG=n
==========

[commit-bot: I haz the power, 2016-01-06 23:38:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-06 23:39:21]

Description was changed from

==========
[es6] Handle function names in object and class literals

This required refactoring ParsePropertyDefinition to pass the parsed
string name as an out param, since ObjectLiteralProperty stores Smis
for Smi-representable property keys.

Computed properties are not yet handled in this patch.

BUG=v8:3699
LOG=n
==========

to

==========
[es6] Handle function names in object and class literals

This required refactoring ParsePropertyDefinition to pass the parsed
string name as an out param, since ObjectLiteralProperty stores Smis
for Smi-representable property keys.

Computed properties are not yet handled in this patch.

BUG=v8:3699
LOG=n

Committed: https://crrev.com/2367abf02579dd2b0643927109bc6d74c502479f
Cr-Commit-Position: refs/heads/master@{#33141}
==========

[commit-bot: I haz the power, 2016-01-06 23:39:22]

Patchset 2 (id:??) landed as
https://crrev.com/2367abf02579dd2b0643927109bc6d74c502479f
Cr-Commit-Position: refs/heads/master@{#33141}