Issue 1563903002: Add public key and signature verification to browser-side API keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1563903002: Add public key and signature verification to browser-side API keys

Created:
4 years, 11 months ago by iclelland

Modified:
4 years, 11 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@keys

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add public key and signature verification to browser-side API keys This adds the ability for experimental API keys to be cryptographically verified in the browser. There is currently a single fixed signing key, whose public key is embeddded in the browser code. This makes use of Ed25519 cryptographic signature verification in boringssl, so boringssl is added as a dependency to content/browser for all platforms (except iOS) BUG=543215

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -12 lines)			Patch
M	content/browser/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
A	content/browser/experiments/api_key_signature_verifier.h	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A	content/browser/experiments/api_key_signature_verifier.cc	View	1 chunk	+55 lines, -0 lines	0 comments	Download
A	content/browser/experiments/api_key_signature_verifier_unittest.cc	View	1 chunk	+72 lines, -0 lines	0 comments	Download
M	content/common/experiments/api_key.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	content/common/experiments/api_key.cc	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	content/common/experiments/api_key_unittest.cc	View	2 chunks	+18 lines, -3 lines	0 comments	Download
M	content/content_browser.gypi	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1521063003 Patch 160001