Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1563893003: media: Fix case ordering of switch statements. (Closed)

Created:
4 years, 11 months ago by servolk
Modified:
4 years, 11 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix case ordering of switch statements. Rearranged case order in IsCodecSupportedOnAndroid and AudioDecoderConfig::GetHumanReadableCodecName as suggested in https://codereview.chromium.org/812643005 BUG=none Committed: https://crrev.com/f9133acc35cd3a1389eb60147a3e41e7233edd41 Cr-Commit-Position: refs/heads/master@{#368204}

Patch Set 1 #

Patch Set 2 : 2 #

Total comments: 6

Patch Set 3 : ps2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M media/base/audio_decoder_config.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M media/base/mime_util.cc View 1 2 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
servolk
4 years, 11 months ago (2016-01-07 02:32:17 UTC) #3
ddorwin
Please be a little more specific in the description. For example, media: Fix case ordering ...
4 years, 11 months ago (2016-01-07 19:44:11 UTC) #4
servolk
Updated the CL description as well https://codereview.chromium.org/1563893003/diff/20001/media/base/audio_decoder_config.cc File media/base/audio_decoder_config.cc (right): https://codereview.chromium.org/1563893003/diff/20001/media/base/audio_decoder_config.cc#newcode120 media/base/audio_decoder_config.cc:120: return "pcm"; On ...
4 years, 11 months ago (2016-01-07 22:08:04 UTC) #6
ddorwin
Please update the first line of the description as I previously suggested. Thanks! LGTM
4 years, 11 months ago (2016-01-07 23:25:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563893003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563893003/40001
4 years, 11 months ago (2016-01-07 23:33:27 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-07 23:55:13 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 23:56:27 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f9133acc35cd3a1389eb60147a3e41e7233edd41
Cr-Commit-Position: refs/heads/master@{#368204}

Powered by Google App Engine
This is Rietveld 408576698