Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1563883004: dart2js Rebase a compiler test whose output has changed. (Closed)

Created:
4 years, 11 months ago by Kevin Millikin (Google)
Modified:
4 years, 11 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js Rebase a compiler test whose output has changed. We are not currently inlining some list printing methods that contain try/catch. TBR=sra@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/47461f8d2c45facff559e129ea6a01ee45483a2c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M tests/compiler/dart2js/js_backend_cps_ir_basic_test.dart View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Kevin Millikin (Google)
TBR'd.
4 years, 11 months ago (2016-01-06 23:01:05 UTC) #1
Kevin Millikin (Google)
Committed patchset #1 (id:1) manually as 47461f8d2c45facff559e129ea6a01ee45483a2c (presubmit successful).
4 years, 11 months ago (2016-01-06 23:01:24 UTC) #3
sra1
4 years, 11 months ago (2016-01-06 23:07:41 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698