Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1563873002: Optimize SkTileImageFilter destination bitmap size. (Closed)

Created:
4 years, 11 months ago by Stephen White
Modified:
4 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Optimize SkTileImageFilter destination bitmap size. The destination bitmap size was not being clipped by the clip bounds, so tiled rendering (ie., clipping to a small region and rendering a SkTileImageFilter with a large dstRect) was much slower than non-tiled rendering. Correctness is covered by unit test ImageFilterDrawTiled, and performance by TileImageFilterBench. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1563873002 Committed: https://skia.googlesource.com/skia/+/b50b97d70a62d90f5266113c9a5ba6cd1b912edd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/effects/SkTileImageFilter.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563873002/1
4 years, 11 months ago (2016-01-06 16:04:19 UTC) #3
Stephen White
Rob: PTAL. Thanks!
4 years, 11 months ago (2016-01-06 16:17:50 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 16:20:42 UTC) #8
robertphillips
lgtm
4 years, 11 months ago (2016-01-06 17:45:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563873002/1
4 years, 11 months ago (2016-01-06 17:45:51 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 17:46:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b50b97d70a62d90f5266113c9a5ba6cd1b912edd

Powered by Google App Engine
This is Rietveld 408576698