Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1563843002: Revert of Show error message for desktop capture related APIs on Aura Android (Closed)

Created:
4 years, 11 months ago by bshe
Modified:
4 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show error message for desktop capture related APIs on Aura Android (patchset #3 id:40001 of https://codereview.chromium.org/1457743002/ ) Reason for revert: We dont need to support Aura Android at current stage. Revert related code. Original issue's description: > Show error message for desktop capture related APIs on Aura Android > > BUG=557285 > > Committed: https://crrev.com/7fb069de3fd47a263587fd24f5136745a1d2c53e > Cr-Commit-Position: refs/heads/master@{#360831} TBR=mfomitchev@chromium.org,sky@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557285 Committed: https://crrev.com/b41bf44692b907932c6c452833e901596aa6e93d Cr-Commit-Position: refs/heads/master@{#367821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
bshe
Created Revert of Show error message for desktop capture related APIs on Aura Android
4 years, 11 months ago (2016-01-06 14:50:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563843002/1
4 years, 11 months ago (2016-01-06 14:50:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 14:50:46 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 14:52:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b41bf44692b907932c6c452833e901596aa6e93d
Cr-Commit-Position: refs/heads/master@{#367821}

Powered by Google App Engine
This is Rietveld 408576698