[Part-2]Add Statistics for SupervisedUserSettingService during merging and syncing data.

chrome/browser/supervised_user/supervised_user_settings_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/supervised_user/supervised_user_settings_service.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 52 matching lines @@
  protected:
   SupervisedUserSettingsServiceTest() : settings_service_(nullptr) {}
   ~SupervisedUserSettingsServiceTest() override {}
 
   scoped_ptr<syncer::SyncChangeProcessor> CreateSyncProcessor() {
     sync_processor_.reset(new syncer::FakeSyncChangeProcessor);
     return scoped_ptr<syncer::SyncChangeProcessor>(
         new syncer::SyncChangeProcessorWrapperForTest(sync_processor_.get()));
   }
 
-  void StartSyncing(const syncer::SyncDataList& initial_sync_data) {
+  syncer::SyncMergeResult StartSyncing(
+      const syncer::SyncDataList& initial_sync_data) {
     scoped_ptr<syncer::SyncErrorFactory> error_handler(
         new MockSyncErrorFactory(syncer::SUPERVISED_USER_SETTINGS));
     syncer::SyncMergeResult result = settings_service_.MergeDataAndStartSyncing(
         syncer::SUPERVISED_USER_SETTINGS, initial_sync_data,
         CreateSyncProcessor(), std::move(error_handler));
     EXPECT_FALSE(result.error().IsSet());
+    return result;
   }
 
   void UploadSplitItem(const std::string& key, const std::string& value) {
     split_items_.SetStringWithoutPathExpansion(key, value);
     settings_service_.UploadItem(
         SupervisedUserSettingsService::MakeSplitSettingKey(kSplitItemName,
                                                            key),
         scoped_ptr<base::Value>(new base::StringValue(value)));
   }
 
@@ skipping 105 matching lines @@
   syncer::SyncError error =
       settings_service_.ProcessSyncChanges(FROM_HERE, change_list);
   EXPECT_FALSE(error.IsSet()) << error.ToString();
   ASSERT_TRUE(settings_);
   ASSERT_TRUE(settings_->GetWithoutPathExpansion(kSettingsName, &value));
   const base::DictionaryValue* dict_value = NULL;
   ASSERT_TRUE(value->GetAsDictionary(&dict_value));
   EXPECT_TRUE(dict_value->Equals(&dict));
 }
 
+TEST_F(SupervisedUserSettingsServiceTest, Merge) {
+  syncer::SyncMergeResult result = StartSyncing(syncer::SyncDataList());
+  EXPECT_EQ(0, result.num_items_added());
+  EXPECT_EQ(0, result.num_items_deleted());
+  EXPECT_EQ(0, result.num_items_modified());
+  EXPECT_EQ(0, result.num_items_before_association());
+  EXPECT_EQ(0, result.num_items_after_association());
+
+  ASSERT_TRUE(settings_);
+  const base::Value* value = NULL;

[Bernhard Bauer, 2016/01/08 16:04:46]

nullptr please.

[Deepak, 2016/01/11 10:38:36]

Done.

+  EXPECT_FALSE(settings_->GetWithoutPathExpansion(kSettingsName, &value));
+
+  base::DictionaryValue dict;
+  dict.SetString("foo", "bar");
+  dict.SetBoolean("awesomesauce", true);
+  dict.SetInteger("eaudecologne", 4711);
+
+  settings_.reset();
+  syncer::SyncDataList sync_data;
+  sync_data.push_back(SupervisedUserSettingsService::CreateSyncDataForSetting(
+      kSettingsName, base::StringValue(kSettingsValue)));
+  for (base::DictionaryValue::Iterator it(dict); !it.IsAtEnd(); it.Advance()) {
+    sync_data.push_back(SupervisedUserSettingsService::CreateSyncDataForSetting(
+        SupervisedUserSettingsService::MakeSplitSettingKey(kSettingsName,
+                                                           it.key()),
+        it.value()));
+  }
+
+  result = StartSyncing(sync_data);
+  EXPECT_EQ(4, result.num_items_added());

[Bernhard Bauer, 2016/01/08 16:04:46]

This is somewhat strange. Why do we add four items? I only see three entries in
the dictionary.

[Deepak, 2016/01/11 10:38:36]

I am adding a entry in sync_data at line 226.
and 3 entry in the sync_data via dictionary. 
So sync_data have total 4 entries.

[Bernhard Bauer, 2016/01/18 17:56:56]

Oh, right. Could you add a comment that explains that we add the three
dictionary entries and this atomic entry?

+  EXPECT_EQ(0, result.num_items_deleted());
+  EXPECT_EQ(0, result.num_items_modified());
+  EXPECT_EQ(0, result.num_items_before_association());
+  EXPECT_EQ(4, result.num_items_after_association());
+
+  sync_data.clear();
+  dict.Clear();
+  dict.SetString("foo", "burp");
+  dict.SetString("item", "first");
+  for (base::DictionaryValue::Iterator it(dict); !it.IsAtEnd(); it.Advance()) {
+    sync_data.push_back(SupervisedUserSettingsService::CreateSyncDataForSetting(
+        SupervisedUserSettingsService::MakeSplitSettingKey(kSettingsName,

[Bernhard Bauer, 2016/01/08 16:04:46]

This only uses split settings. It would be good to also exercise the code for
some atomic settings and queued items.

[Deepak, 2016/01/11 10:38:36]

Done.

+                                                           it.key()),
+        it.value()));
+  }
+
+  result = StartSyncing(sync_data);
+  EXPECT_EQ(1, result.num_items_added());
+  EXPECT_EQ(3, result.num_items_deleted());
+  EXPECT_EQ(1, result.num_items_modified());
+  EXPECT_EQ(4, result.num_items_before_association());
+  EXPECT_EQ(2, result.num_items_after_association());
+}
+
 TEST_F(SupervisedUserSettingsServiceTest, SetLocalSetting) {
   const base::Value* value = NULL;
   EXPECT_FALSE(settings_->GetWithoutPathExpansion(kSettingsName, &value));
 
   settings_.reset();
   settings_service_.SetLocalSetting(
       kSettingsName,
       scoped_ptr<base::Value>(new base::StringValue(kSettingsValue)));
   ASSERT_TRUE(settings_);
   ASSERT_TRUE(settings_->GetWithoutPathExpansion(kSettingsName, &value));
@@ skipping 71 matching lines @@
   // The uploaded items should not show up as settings.
   const base::Value* value = NULL;
   EXPECT_FALSE(settings_->GetWithoutPathExpansion(kAtomicItemName, &value));
   EXPECT_FALSE(settings_->GetWithoutPathExpansion(kSplitItemName, &value));
 
   // Restarting sync should not create any new changes.
   settings_service_.StopSyncing(syncer::SUPERVISED_USER_SETTINGS);
   StartSyncing(sync_data);
   ASSERT_EQ(0u, sync_processor_->changes().size());
 }