Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1563823002: Allow placeholders when the native_libs is empty. (Closed)

Created:
4 years, 11 months ago by Xi Han
Modified:
4 years, 11 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow placeholders when the native_libs is empty. Committed: https://crrev.com/536d81764191b86be7a61978ad35694b0f0e78e2 Cr-Commit-Position: refs/heads/master@{#367825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/config/android/rules.gni View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xi Han
Hi Andrew, please take a look of this change made for placeholders. Thanks!
4 years, 11 months ago (2016-01-06 14:34:53 UTC) #2
agrieve
On 2016/01/06 14:34:53, Xi Han wrote: > Hi Andrew, please take a look of this ...
4 years, 11 months ago (2016-01-06 14:40:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563823002/1
4 years, 11 months ago (2016-01-06 14:41:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 15:36:10 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 15:37:08 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/536d81764191b86be7a61978ad35694b0f0e78e2
Cr-Commit-Position: refs/heads/master@{#367825}

Powered by Google App Engine
This is Rietveld 408576698