Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: runtime/vm/flow_graph_builder.h

Issue 1563703005: Remove unreachable exits from the list collected by InlineExitCollector. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Fix bug: graph can change between RemoveUnreachableExits and SortExits Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.h
diff --git a/runtime/vm/flow_graph_builder.h b/runtime/vm/flow_graph_builder.h
index e276a09965510f4e23ef8ec192820894ebcc91cb..41bd751a02de2d900d50e2092ec9eb7c26ca43ad 100644
--- a/runtime/vm/flow_graph_builder.h
+++ b/runtime/vm/flow_graph_builder.h
@@ -42,6 +42,8 @@ class InlineExitCollector: public ZoneAllocated {
// Before replacing a call with a graph, the outer environment needs to be
// attached to each instruction in the callee graph and the caller graph
// needs to have its block and instruction ID state updated.
+ // Additionally we need to remove all unreachable exits from the list of
+ // collected exits.
void PrepareGraphs(FlowGraph* callee_graph);
// Inline a graph at a call site.
@@ -78,6 +80,7 @@ class InlineExitCollector: public ZoneAllocated {
static int LowestBlockIdFirst(const Data* a, const Data* b);
void SortExits();
+ void RemoveUnreachableExits(FlowGraph* callee_graph);
Definition* JoinReturns(BlockEntryInstr** exit_block,
Instruction** last_instruction,
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698