Allow disabling upload rate-limiting

Allow disabling upload rate-limiting in crashpad_handler

This is a temporary measure to try to account for lower than expected
upload volume from Chrome in the wild. So this doesn't fix bug 23, but
is related. The ability to delimit the upload rate is useful when
testing locally too.

R=mark@chromium.org
BUG=crashpad:23
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/330adfb02984692135fc5989dbaff49adb3b757e

[scottmg, 2016-01-06 00:01:13]

Description was changed from

==========
Allow disabling upload rate-limiting in crashpad_handler

This is a temporary measure to try to account for lower than expected
upload volume from Chrome in the wild. So this doesn't fix bug 23, but
is related; the ability to delimit the upload rate is useful when
testing locally too.

BUG=crashpad:23
==========

to

==========
Allow disabling upload rate-limiting in crashpad_handler

This is a temporary measure to try to account for lower than expected
upload volume from Chrome in the wild. So this doesn't fix bug 23, but
is related. The ability to delimit the upload rate is useful when
testing locally too.

BUG=crashpad:23
==========

[scottmg, 2016-01-06 00:04:16]

Description was changed from

==========
Allow disabling upload rate-limiting in crashpad_handler

This is a temporary measure to try to account for lower than expected
upload volume from Chrome in the wild. So this doesn't fix bug 23, but
is related. The ability to delimit the upload rate is useful when
testing locally too.

BUG=crashpad:23
==========

to

==========
Allow disabling upload rate-limiting in crashpad_handler

This is a temporary measure to try to account for lower than expected
upload volume from Chrome in the wild. So this doesn't fix bug 23, but
is related. The ability to delimit the upload rate is useful when
testing locally too.

R=mark@chromium.org
BUG=crashpad:23
==========

[scottmg, 2016-01-06 00:04:16]

scottmg@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2016-01-06 15:52:41]

It was always my intention for rate-limiting to be controlled by the database
settings, but this is fine as a temporary measure. But could you leave a
comment, I guess in handler_main.cc, that this is temporary and that it should
be removed when $x happens? And maybe have a bug tracking that?

LGTM

https://codereview.chromium.org/1563683002/diff/20001/handler/crashpad_handle...
File handler/crashpad_handler.ad (right):

https://codereview.chromium.org/1563683002/diff/20001/handler/crashpad_handle...
handler/crashpad_handler.ad:143: *--no-rate-limit*::
It was intended that these arguments be sorted, but I guess --handshake-handle
is already out of order.

https://codereview.chromium.org/1563683002/diff/20001/handler/handler_main.cc
File handler/handler_main.cc (right):

https://codereview.chromium.org/1563683002/diff/20001/handler/handler_main.cc...
handler/handler_main.cc:85: "      --no-rate-limit         don't rate limit
crash uploads\n"
Same here (although it means more stupid #ifdefs).

https://codereview.chromium.org/1563683002/diff/20001/handler/handler_main.cc...
handler/handler_main.cc:138: kOptionNoRateLimit,
and this and the option struct and the switch block too.

[scottmg, 2016-01-06 17:48:11]

Thanks

https://codereview.chromium.org/1563683002/diff/20001/handler/crashpad_handle...
File handler/crashpad_handler.ad (right):

https://codereview.chromium.org/1563683002/diff/20001/handler/crashpad_handle...
handler/crashpad_handler.ad:143: *--no-rate-limit*::
On 2016/01/06 15:52:41, Mark Mentovai wrote:
> It was intended that these arguments be sorted, but I guess --handshake-handle
> is already out of order.

Done.

https://codereview.chromium.org/1563683002/diff/20001/handler/handler_main.cc
File handler/handler_main.cc (right):

https://codereview.chromium.org/1563683002/diff/20001/handler/handler_main.cc...
handler/handler_main.cc:85: "      --no-rate-limit         don't rate limit
crash uploads\n"
On 2016/01/06 15:52:41, Mark Mentovai wrote:
> Same here (although it means more stupid #ifdefs).

Done.

https://codereview.chromium.org/1563683002/diff/20001/handler/handler_main.cc...
handler/handler_main.cc:138: kOptionNoRateLimit,
On 2016/01/06 15:52:41, Mark Mentovai wrote:
> and this and the option struct and the switch block too.

Done. Yuck.

[Mark Mentovai, 2016-01-06 17:51:50]

LGTM

Yeah, sorry, it’s uglier, but it’s also sortier!

https://codereview.chromium.org/1563683002/diff/40001/handler/handler_main.cc
File handler/handler_main.cc (right):

https://codereview.chromium.org/1563683002/diff/40001/handler/handler_main.cc...
handler/handler_main.cc:187: {"no-rate-limit", no_argument, nullptr,
kOptionNoRateLimit},
Do the ugly dance with this one too.

https://codereview.chromium.org/1563683002/diff/40001/handler/handler_main.cc...
handler/handler_main.cc:394: //
https://bugs.chromium.org/p/crashpad/issues/detail?id=23
Short links, https://crashpad.chromium.org/bug/23

[scottmg, 2016-01-06 17:55:37]

https://codereview.chromium.org/1563683002/diff/40001/handler/handler_main.cc
File handler/handler_main.cc (right):

https://codereview.chromium.org/1563683002/diff/40001/handler/handler_main.cc...
handler/handler_main.cc:187: {"no-rate-limit", no_argument, nullptr,
kOptionNoRateLimit},
On 2016/01/06 17:51:50, Mark Mentovai wrote:
> Do the ugly dance with this one too.

Done.

https://codereview.chromium.org/1563683002/diff/40001/handler/handler_main.cc...
handler/handler_main.cc:394: //
https://bugs.chromium.org/p/crashpad/issues/detail?id=23
On 2016/01/06 17:51:50, Mark Mentovai wrote:
> Short links, https://crashpad.chromium.org/bug/23

Ah, I can never remember what the shorter version is. I tried
bugs.chromium.org/crashpad/23 and crashpad.chromium.org/bugs/23 and then gave
up. :)

Done.

[scottmg, 2016-01-06 17:59:59]

Description was changed from

==========
Allow disabling upload rate-limiting in crashpad_handler

This is a temporary measure to try to account for lower than expected
upload volume from Chrome in the wild. So this doesn't fix bug 23, but
is related. The ability to delimit the upload rate is useful when
testing locally too.

R=mark@chromium.org
BUG=crashpad:23
==========

to

==========
Allow disabling upload rate-limiting in crashpad_handler

This is a temporary measure to try to account for lower than expected
upload volume from Chrome in the wild. So this doesn't fix bug 23, but
is related. The ability to delimit the upload rate is useful when
testing locally too.

R=mark@chromium.org
BUG=crashpad:23

Committed:
https://chromium.googlesource.com/crashpad/crashpad/+/330adfb02984692135fc598...
==========

[scottmg, 2016-01-06 18:00:01]

Committed patchset #5 (id:80001) manually as
330adfb02984692135fc5989dbaff49adb3b757e (presubmit successful).