core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp - Issue 1563673002: Cleanup includes, comments, and unused code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

Issue 1563673002: Cleanup includes, comments, and unused code (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

index 4aa99d08e33ace4766b20d12d3b3528e6d234784..e19516a15dfbca8efec57d5c4e536ecb4b67f77e 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

@@ -4,8 +4,6 @@

-#include "parser_int.h"

Lei Zhang 2016/01/06 00:05:33 This one was wrong. I should have put core/include

Wei Li 2016/01/06 04:46:24 Done.

#include <algorithm>

#include <memory>

#include <set>

@@ -18,6 +16,7 @@

#include "core/include/fxcrt/fx_ext.h"

#include "core/include/fxcrt/fx_safe_types.h"

#include "core/src/fpdfapi/fpdf_page/pageint.h"

+#include "core/src/fpdfapi/fpdf_parser/parser_int.h"

#include "third_party/base/stl_util.h"

namespace {